Bug 173546

Summary: KMessageBox' palette screws up scrollbars for some styles
Product: [Frameworks and Libraries] kdelibs Reporter: Huynh Huu Long <long>
Component: kdeuiAssignee: kdelibs bugs <kdelibs-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: uwolfer
Priority: NOR    
Version: 4.1   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed In:
Attachments: patch from KDE/kdelibs/kdeui
updated patch

Description Huynh Huu Long 2008-10-26 00:25:42 UTC 
Version:            (using Devel)
OS:                Linux
Installed from:    Compiled sources

KMessageBox forces the ScrollArea to have a transparent background (for example to fit with custom backgrounds like the oxyegn gradient). Unfortunately also the scrollbars are affected and especially Plastique's but also Oxygen's scrollbars don't look as expected. Instead only the viewports palette should be modified, if at all.

examples:
kdialog --msgbox "`cat Makefile`" --style=plastique
kdialog --msgbox "`cat WhateverFile`" --style=oxygen
Comment 1 Huynh Huu Long 2008-10-26 00:27:29 UTC 
Created attachment 28145 [details]
patch from KDE/kdelibs/kdeui

Here's a proposal patch
Comment 2 Urs Wolfer 2008-10-26 10:29:16 UTC 
Patch looks good to me. Though I'm not sure if this line is required at all:
+        if (messageScrollArea->viewport())
+        {

(if it is, please write as:
+        if (messageScrollArea->viewport()) {
)
Comment 3 Huynh Huu Long 2008-10-26 16:05:56 UTC 
Created attachment 28161 [details]
updated patch

You're right, that check doesn't make much sense :) I was just a bit paranoid :P
Comment 4 Huynh Huu Long 2008-10-26 16:32:42 UTC 
SVN commit 876135 by huynhhuu:

Fix graphical errors with some styles. We only need to set the viewport transparent, not the scrollbars.
BUG: 173546


 M  +1 -1      kmessagebox.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=876135