Summary: | Erratic behaviour of track detail editor | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | Vesa Muhonen <vesa.muhonen> |
Component: | general | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | teo |
Priority: | NOR | Keywords: | needs_verification |
Version: | 2.0-beta | ||
Target Milestone: | --- | ||
Platform: | openSUSE | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: |
Patch to solve problem with year and track number
Patch to solve problem with year and track number |
Description
Vesa Muhonen
2008-10-15 21:45:14 UTC
Created attachment 27968 [details]
Patch to solve problem with year and track number
Created attachment 27969 [details]
Patch to solve problem with year and track number
Sorry for last patch, it's incorrect....this is correct and solve problem wit changing year and track number
Comment on attachment 27968 [details]
Patch to solve problem with year and track number
Teo can you please have a look at the patch? Andrey: Thanks a lot :) That's not my code but the patch makes sense. I committed the patch to amarok trunk. SVN commit 872603 by mrnjavac: Fix borked behavior of tag dialog with year and track number. Thanks Andrey Esin for the patch. This partially closes bug 172896. As said, the patch seems to have fixed the issue with year and track number, but another issue still remains: When editing the tags for whole album at once, like setting a disc number, comment and composer fields are deleted unless they contain the same string for all tracks. Also, editing the details of a single track sets the disc number of that track to '0' if no disc number was specified. ps. This is related to the original report, but should this be reported as separate bug? I think there is another report about this already. If it is marked as fixed please reopen. Couldn't find a previous bug concerning this. There was one concerning that the tags were not written to the file, but that's no the case here. The original bug report was a bit vague, contained separate issues and is partially fixed. Thus I opened a new report (bug 174574) for the comment / composer tags being deleted. I close this one as it was done after the partial fix. |