Bug 172560

Summary:	Folderview should be reversed in RTL desktops?
Product:	[Unmaintained] plasma4	Reporter:	Diego Iastrubni <elcuco>
Component:	widget-folderview	Assignee:	Plasma Bugs List <plasma-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	aseigo, asraniel, kde-2011.08
Priority:	NOR	Keywords:	rtl
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Unspecified
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Diego Iastrubni 2008-10-11 01:27:13 UTC

Version:            (using Devel)
Installed from:    Compiled sources

When plasma is running in RTL mode (test with --reverse) the icons position should be mirrored on the X axis. 

Before closing this bug we should test if this is desired... so in theory, a hacker can work on supporting this, and after testing we will dump this feature. Be prepared :)

Comment 1 Diego Iastrubni 2008-10-11 01:51:28 UTC

If anyone wants to mark 118929 as a dup:
https://bugs.kde.org/show_bug.cgi?id=118929

This one is for plasma, and 118929 is for kdesktop. In practice both ask for the same thing, but in different applications/technologies.

Comment 2 Aaron J. Seigo 2008-10-18 22:21:22 UTC

this is a bug in Qt, the QGraphics*Layout classes do not get notified of layout direction.

Comment 3 Aaron J. Seigo 2008-10-18 22:21:40 UTC

*** Bug 172558 has been marked as a duplicate of this bug. ***

Comment 4 Aaron J. Seigo 2008-10-18 22:29:37 UTC

urg.. comment #2 was actually supposed to be on bug #172559 ...

as for dup'ing the kdesktop one, they are separate apps so shouldn't be marked
as duplicates.

Comment 5 Diego Iastrubni 2008-10-18 22:47:59 UTC

Aaron,

172558 should be fixed by replacing QGraphicsLinearLayout (or implementing a smarter one), and this one by fixing the layout manager used for the dashboard (based on QGraphicsGridLayout ..? or are we using it directly?)

IMHO those are separate tasks and not dups.

Comment 6 Diego Iastrubni 2008-10-18 22:55:30 UTC

urg... please ignore my previous comment. it for another bug. sorry for the noise.

Comment 7 Dotan Cohen 2008-12-29 20:16:59 UTC

When working in a Hebrew UI, I think in terms of Right to Left, so it would be very confusing for me if the UI was still LTR. I am in favor of this bug.

Note that I feel that this bug is now a dupe of 118929 (since it is moved to plasma) so I will cross post there as well. I will let the OP mark as dupe to be sure, however.

Comment 8 Aaron J. Seigo 2008-12-29 22:00:31 UTC

*** Bug 118929 has been marked as a duplicate of this bug. ***

Comment 9 Fredrik Höglund 2009-03-29 17:32:26 UTC

SVN commit 946543 by fredrik:

* Add right-to-left, top-to-bottom and top-to-bottom, right-to-left icon
  arrangement modes.
* Default to a right-to-left arrangement when in RTL mode.
* Show the scrollbar on the left side of the icon view when in RTL mode.

BUG: 172560
BUG: 176449


 M  +11 -6     folderview.cpp  
 M  +3 -2      folderview.h  
 M  +108 -39   iconview.cpp  
 M  +8 -6      iconview.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=946543