Summary: | embedded browser tabs can not be closed using ctrl w | ||
---|---|---|---|
Product: | [Applications] akregator | Reporter: | Anders Lund <anderslund> |
Component: | akregator konqueror plugin | Assignee: | kdepim bugs <kdepim-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | aermler, christophe, haakon+kdebugs, kari.argillander, langec, magnus, tuju, winter |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: | |||
Attachments: | Make Ctrl-W work |
Description
Anders Lund
2008-09-24 22:29:21 UTC
What works for me in 1.3.3 (KDE 4.1.3) is: 1. press Ctrl+W twice, which focuses the close button in the tab bar 2. then I can press this button with Space 3. … and must remember not to hit Space for scrolling down the next article that I'm reading, as the close button will remain focused. I can confirm comment #1 I still have this problem in KDE 4.2 RC1 (4.1.96) or Akregator 1.3.50. Nothing happens when I hit CTRL+W once, when I hit it twice there's a notification: "Ambigious shortcut detected The key sequence 'Ctrl+W' is ambiguous. Use 'Configure Shortcuts' from the 'Settings' menu to solve the ambiguity. No action will be triggered." But when I use "Configure Shortcuts" the only shortcut assigned to CTRL+W is "Close Tab". I can confirm this happens in akregator 1.4.0, KDE 4.2 (from opensuse factory rep.). Created attachment 32342 [details]
Make Ctrl-W work
It seems the problem was that the shortcut was being set twice; once in actionmanagerimpl.cpp and once in tabwidget.cpp. The attached patch removes the one in tabwidget.cpp. It also fixes a bug where Ctrl-W would stop working after being pressed when viewing the article list.
SVN commit 944029 by osterfeld: Fix tab-related shortcuts, including Alt+W Issue spotted by Haakon Nilsen BUG: 171615 _M . (directory) M +14 -17 akregator/src/tabwidget.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=944029 SVN commit 944228 by osterfeld: backport: CCBUG: 171615 r944038 | osterfeld | 2009-03-24 21:45:04 +0000 (Tue, 24 Mar 2009) | 2 lines actually use frame var ------------------------------------------------------------------------ r944029 | osterfeld | 2009-03-24 21:32:52 +0000 (Tue, 24 Mar 2009) | 4 lines Fix tab-related shortcuts, including Alt+W Issue spotted by Haakon Nilsen M +18 -18 tabwidget.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=944228 |