| Summary: | Text in subject line is always black | ||
|---|---|---|---|
| Product: | [Unmaintained] kmail | Reporter: | Peter Lewis <pete> |
| Component: | composer | Assignee: | kdepim bugs <kdepim-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | 1.10.0 | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Peter Lewis
2008-07-24 11:44:06 UTC
I can't reproduce it, for me it uses the KDE colorscheme (white on black). Do you have custom colors enabled in the config? Hmmm... yes I do actually. But there doesn't seem to be anywhere in the custom colours configuration options to change it. Right, configuring the text foreground color is not possible (it is "normal text" I think, but the setting doesn't take effect), and I wasn't able to fix that by looking at the issue for a few minutes. I'm actually thinking of removing the color options altogether, I don't see why they would be needed when there is a KDE color scheme. I'm curious what you need custom colors for and why the KDE color scheme is not enough for you. Hmm... well I've always found the custom colours in KMail really useful. I guess my main reason is to make the application more usable with different KDE colour schemes. Specifically, I usually change the following to suit the colour scheme I have: 1) colours for different message statuses in the message list (i.e. unread, new, important, action item etc). If you choose a KDE colour scheme which uses a colour similar to one of the default message colours, it's hard to see it. Obviously, if they were hard-coded, then this would not be good. Perhaps this will also be important with message tagging too. 2) The same goes for the colours used for hyperlinks and quoted text in messages. 3) The colours used in messages to represent the various "signed" and "encrypted" wrappers also need to be adjusted to fit whichever colour scheme you choose. I hope this some insight - please don't remove the custom colour functionality without considering these cases :-) Though if this was somehow to be worked into the general KDE colour scheme settings system, then that's obviously fine too. I notice it's improved since 3.5.9. Thanks. PS. If you want more info, I'm happy to provide a few screenshots. OK, I see your points, those color configs you mentioned should indeed stay. The proper solution would of course be to calculate colors for the things you mentioned based on the color scheme, to give good contrast, but that is probably not easy to do and not 100% foolproof. Now that I look at it, I would only remove the following: - Background / Alternative Background color: These change the background of the list views and the composer fields. Since these can already changed by the KDE color scheme, I see no reason to keep them (plus they are buggy, for example the background of the message structure viewer is not changed). - Normal Text: Same here, it changes the text color of the composer (doesn't work for the subject field right now, another bug) and the list views, but that is already provided by the color scheme as well. This would also probably solve your problem: Since the subject line wouldn't have custom colors anymore, it would just work fine, since it uses the KDE colors then. What do you think about this? I think that sounds quite sensible, yes, since the items you mention are basically a duplication of functionality. I can see why you'd want to remove that kind of thing. Thanks for considering this - I'm colour blind so I find it quite important to be able to adjust colours in order to make my desktop more usable. For example, I don't like having red and green message wrappers, since they look very similar to me. I doubt that any "automatic" calculation of colours would be able to account for the many different types of colour blindness which exist, so I think it's good to keep the option to choose your own colours there. SVN commit 837712 by tmcguire: Remove the ability to set custom background and foreground colors. Reasons: - It was buggy (the recipientseditor, mimeparttree etc didn't obey to it) - It is already provided by the KDE colorscheme (unlike the other color options) Also, the ApplicationPaletteChange event is no longer used, so listen to PaletteChange events instead. BUG:102906 BUG:167346 M +1 -7 configuredialog.cpp M +2 -4 csshelper.cpp M +3 -7 favoritefolderview.cpp M +1 -11 foldertreebase.cpp M +0 -6 kmail.kcfg M +1 -45 kmcomposewin.cpp M +0 -10 kmcomposewin.h M +1 -18 kmheaders.cpp M +1 -1 kmreaderwin.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=837712 |