| Summary: | dropdown completion in location bar gets falsely updated | ||
|---|---|---|---|
| Product: | [Applications] konqueror | Reporter: | Benno Dielmann <kde> |
| Component: | general | Assignee: | Konqueror Developers <konq-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | andresbajotierra, faure, jk, jwork123nl, kde-bugs, kde, kde, kde, kde_bugzilla_2 |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Benno Dielmann
2008-07-21 13:36:15 UTC
Sorry, I didn't expect the example items would become links... They are just meant to be example history items... (KDE 4.0.99 (4.1RC1+) in ArchLinux) I can reproduce this bug Using KDE 4.1.00 (KDE 4.1.0) (KDEmod) in ArchLinux i686: I can still reproduce this bug Here using: Qt: 4.4.3 + qt-copy-patches-889120 KDE: 4.2.60 (KDE 4.2.60 (KDE 4.3 >= 20090106)) kdelibs svn rev. 907834 / kdebase svn rev. 907837 on ArchLinux x86_64 - Kernel 2.6.27.10 I can still reproduce this Yes, this behavior is very annoying and should be implemented like it was in KDE 3.5.x and is described by the bug reporter. I'm now using 4.1.4 and the location bar is in very bad shape, I can't use tab to go thru the drop down items, hitting tab closes the list! And since my upgrade from 4.1.3 to 4.1.4, the location bar doesn't even search my bookmarks... I'm confirming that hitting tab in the location bar removes the autocomplete dropdown with KDE 4.2. For me, this makes the autocomplete pretty useless. From: kdebase/apps/konqueror/konqcombo.cpp:144 // we use KUrlCompletion, so let KLineEdit handle Key_Tab so that subdir<tab>/subdir<tab> works (#65877). // KCompletionBox's handling of Key_Tab is just the same as Up/Down keys, not very useful. completionBox()->setTabHandling(false); Commenting out the last line makes the Tab function work OK but I don't know if this affect anything else (bug 65877 ?) Judging by the way the comment is phrased, I suspect it was just an on-a-whim change by someone who didn't think about how some people prefer to not have to lift their right hand off the keyboard and move it just to select a completion. I have sent an email to the maintainers/commiters about this. They will know what to do. No, I didn't add that line "on a whim" nor "without thinking" -- but at the time it didn't break Tab-goes-next-in-completion, it only fixed the usage of Tab when completion local urls -- and this line was from KDE 3.x, so it's not the problem. I'll investigate. OK, it wasn't in KDE-3.x, it was in May 2008 -- but something must have changed later on. I swear it worked back then :-) Well... it actually didn't work ;-) That's what this bug report originally was about... The tab-ceased-to-work bug was introduced with KDE 4.1.4 (at least on my Kubuntu Intrepid) So in May 2008, the dropdown at least didn't disappear, but cycling through the dropdown entries didn't work... SVN commit 920746 by dfaure: Re-enable handling of Tab BUG: 167135 M +2 -4 konqcombo.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=920746 *** Bug 179123 has been marked as a duplicate of this bug. *** Merci, David, for working on this bug. But, are you sure the bug you marked as a duplicate really is one? This bug report here originally wasn't about the Tab key closing the drop down list but about the completion going wrong (see above). Comments on it got slightly off-topic... Is the original bug as reported above fixed by your commit, too? Yes it works fine now (no re-filtering on <tab> if there are multiple items in the dropdown), since I re-enabled the code that makes "Tab" go "Down". Hmm I cc'ed this bug on another commit but it didn't come through: SVN commit 920743 by dfaure: Better fix for 65877, which doesn't require disabling "Tab means Down" in the completion box (#167135 says some people like that :-). I think I found a solution that makes everyone happy: if there's only one entry then Tab autoselects the first entry and completes again, allowing to use it like a shell for local files: /hom<tab>dfau<tab>Docu<tab> for /home/dfaure/Documents. If there's more than one entry, then Tab does "Down" as before. David, that sounds great, thank you! Maybe it is already this way, but can you make Shift + Tab go up in the list? If I recall correctly, this was like so back then and it would be nice to have it again... Thanks for the good work, David! *** Bug 171895 has been marked as a duplicate of this bug. *** *** Bug 184107 has been marked as a duplicate of this bug. *** |