| Summary: | The terminal in Dolphin should stop emitting "cd xxx" commands once an application is running in the terminal | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | Andreas Hoenselaar <ahoenselaar> |
| Component: | general | Assignee: | Peter Penz <peter.penz19> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | andresbajotierra, archakbasak, bko, finex, robertknight |
| Priority: | NOR | ||
| Version First Reported In: | 16.12.2 | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
|
Description
Andreas Hoenselaar
2008-06-20 01:57:29 UTC
I agree with Andreas. SVN commit 946382 by rduran: BUG: 164489 Make Dolphin benefit from new TerminalInterfaceV2 functions. M +12 -4 terminalpanel.cpp M +2 -2 terminalpanel.h WebSVN link: http://websvn.kde.org/?view=rev&revision=946382 Also, when I type a command but do not hit enter and change directory in the GUI the "cd xxx\n" is emitted so a messed up command is executed. This is very bad if I type "rm -r " and decide to change directory before I finish typing the command. Judging from looking at the code, Rahmans fix doesn't seem to change this behaviour, but I couldn't test it. So could this bug be reopened or shall I file a new bug? > Judging from looking at the code,
> Rahmans fix doesn't seem to change this behaviour, but I couldn't test it.
If I remember correctly, he ran into the anticipated problem that the terminal view doesn't know what it is displaying or what the user's input means and so we don't know that the user has typed a command and has not yet pressed enter.
Bug 161637 seems to be related to this. |