Bug 159789

Summary:	Support %SIGNATURE in templates
Product:	[Unmaintained] kmail	Reporter:	Janet <bugzilla>
Component:	templates	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bluedzins, cwoods, gpowell, isleshocky77, johnwheaton2, jon.armond, lemma, linux, null, ruchir.brahmbhatt
Priority:	NOR	Keywords:	triaged
Version:	SVN trunk (KDE 4)
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Janet 2008-03-24 14:22:04 UTC

Version:           1.9.9 (using 3.5.9, Debian Package 4:3.5.9.dfsg.1-2 (lenny/sid))
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.24-2.6.24.3.slh.6-sidux-686

When I configure kmail to "Insert signatures above quoted text" the following happens:

1. the signature is at the beginning of the mail - but the beginning of the mail is not where that signature is expected, it just is expected to be above the quoted text. Imagine you are using custom templates for certain folders/people and your template looks like this:

Hello %TOFNAME,

%CURSOR

------ Your message from %ODATE, %OTIME: ------
%QUOTE

In this case the beginning of the mail (and the place where the signature is put to) is above "Hello %TOFNAME,". Expected place is above %QUOTE or better of course above "------ Your message..." or below "%CURSOR".

2. When you also use a template for creating a *new* mail which shall contain just a "Hello" at the beginning (lazy, I know) the signature also is placed *above* that "Hello" - although it is not a reply and there is no quoted text.

Maybe this can be resolved by adding a %SIGNATURE command to the templates?

The 3. error is that there's no "-- " above the signature anymore, you have to add it by hand (and *that* also happens when you start a new mail without custom template, no "-- " anymore). When I deactivate "Insert signatures above quoted text" instantly all mails/signatures again have this "-- ".

Comment 1 Thomas McGuire 2008-03-31 01:09:54 UTC

Yes, I think the only way to solve 1) and 2) is to add %SIGNATURE support to templates.
See also bug 6376.

3) is already solved in trunk.

Comment 2 Thomas McGuire 2008-08-01 00:26:34 UTC

*** Bug 167793 has been marked as a duplicate of this bug. ***

Comment 3 Maciej Pilichowski 2008-08-28 19:23:39 UTC

ad.2) and not only this -- I have a lot of reply templates now, official, and not, in polish, and english and quite obviously one signature does not fit in all cases, so I have only one and delete it manually each time it is inappropriate for mail I am sending (till now I always remembered to delete it :-) )

Comment 4 Norman Schmidt 2009-01-19 11:56:06 UTC

*** Bug 180870 has been marked as a duplicate of this bug. ***

Comment 5 Ruchir Brahmbhatt 2009-02-23 17:11:17 UTC

I also vote for this.

Comment 6 Ruchir Brahmbhatt 2009-02-24 08:13:17 UTC

*** This bug has been confirmed by popular vote. ***

Comment 7 Jaime Torres 2009-04-02 19:52:03 UTC

*** Bug 188647 has been marked as a duplicate of this bug. ***

Comment 8 Michael Leupold 2009-04-04 12:02:51 UTC

I can still confirm this bug on trunk r948809.

Comment 9 John Wheaton 2009-07-01 14:23:13 UTC

I'm chasing the series of duplicate bugs around.  The issue I'm trying to find and report/support is the cursor not being placed where the "CURSOR" marker is.  this is my template:

%CURSOR

%REM="Default reply template"%-
On %ODATE %OTIMELONG you wrote:
%QUOTE

Expected results:  the cursor should be at the top of the reply message.
Actual results:  the cursor ends up at the bottom of the email.

I am using kmail in KDE 4.2.2.

Comment 10 Jonathan Armond 2009-07-01 17:19:38 UTC

(In reply to comment #9)
This seems to be solved in trunk. Probably 4.3 too.

Comment 11 Jonathan Armond 2009-07-20 15:40:39 UTC

SVN commit 999765 by jarmond:

Implement %SIGNATURE template command to allow customised signature
insertion location.

FEATURE: 6376
FEATURE: 159789

 M  +24 -0     kmail/templateparser.cpp  
 M  +6 -0      kmail/templateparser.h  
 M  +3 -0      kmail/templatesinsertcommand.cpp  
 M  +1 -1      kmail/templatesinsertcommand.h  
 M  +4 -28     libkdepim/kmeditor.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=999765

Comment 12 Jaime Torres 2009-08-03 16:55:51 UTC

*** Bug 190642 has been marked as a duplicate of this bug. ***