Bug 155689

Created attachment 23012 [details]
Backtrace of one the crashes

Tried on 761006.
browsing on "smb://..." doesn't make crash dolphin.
It crash instead on "remote://smb-network".

I've no backtrace, but this output on the shell:


dolphin(9280)/kdecore (KConfigSkeleton) KCoreConfigSkeleton::KCoreConfigSkeleton: Creating KCoreConfigSkeleton ( 0x829e808 )
dolphin(9280)/kio (KDirLister) KDirLister::stop:
dolphin(9280)/kio (KDirListerCache) KDirListerCache::listDir: DolphinDirLister(0x8163180) url= KUrl("remote://smb-network") keep= false reload= false
dolphin(9280)/kio (KDirListerCache) KDirListerCache::forgetDirs: DolphinDirLister(0x8163180)  item moved into cache:  KUrl("file:///home/test")
dolphin(9280)/kio (KDirListerCache) KDirListerCache::listDir: Entry not in cache or reloaded: KUrl("remote://smb-network")
dolphin(9280)/kio (Slave) KIO::Slave::createSlave: createSlave ' "remote" ' for  "remote://smb-network"
dolphin(9280)/kio (KIOConnection) KIO::ConnectionServer::listenForRemote: Listening on  "local:/tmp/test-kde4/ksocket-test/dolphinsj9280.slave-socket"
dolphin(9280)/kio (KDirListerCache) KDirListerCache::slotEntries: new entries for  KUrl("remote://smb-network")
ASSERT: "result.second" in file /home/test/kdesvn/kdelibs/kio/kio/kdirmodel.cpp, line 304
dolphin(9280)/kio (KDirListerCache) KDirListerCache::~KDirListerCache: -KDirListerCache
dolphin(9280)/kio (KDirWatch) KDirWatchPrivate::removeEntry: KDirWatchPrivate::removeEntry for "/home/test" sub_entry: 0x0
dolphin(9280)/kio (KDirWatch) KDirWatchPrivate::removeEntry: Cancelled INotify (fd 15, 1) for "/home/test"
dolphin(9280)/kio (KDirWatch) KDirWatchPrivate::removeEntry: Removed Dir "/home/test" for "" ["KDirWatch-1"]

forgot to add:

If you enter a valid Host address like "smb://localhost" dolphin does not crash. It only crash when it has to list the aviable hosts, happening when you enter smb:/ to list all avaible workgroups and smb://name_of_workgroup

i've been diggin into the source... looks like some serious problem of understanding between kio_smb and the model of KDE for the Kios.

By the way... is it possible that kio_smb remains untouched since KDe2 ?

*** Bug 158445 has been marked as a duplicate of this bug. ***

Confirmed here.

Listing hosts make kio-enabled apps to crash spectacularly, but when specifying the host, as in smb://hostname/, I can access them.

Should this be a blocker for 4.1, specially with KDE for Windows?

the crash is not in smb:/ - only triggered by it

I think this has been fixed already, by Albert?

Yeah, i fixed it in 4.1, did not backport to 4.0 because it does not have all the necesary changes to make it work

Can i ask about a summary introduced to fix this? Maybe a rewrite of the kio_smb? I am curious, because i looked into the code and it seemed to me that the problem was that this kio was left behind in the effort of porting.... ???

"Can i ask about a summary introduced to fix this?"

Can i ask for a summary of the changes introduced  to fix this ?

Sorry, i shouldn't write in the bugtracker after studying finite element method... i makes me dizzy :)

The use of UDS_URL to make a non-hierarchical structure, was the problem. Solved with UDS_TARGET_URL,
which only triggers when clicking on the item, but the URL used for that item it still the normal (part of the hierarchical
URL structure) one.

*** Bug 162458 has been marked as a duplicate of this bug. ***

*** Bug 162465 has been marked as a duplicate of this bug. ***

SVN commit 891707 by dfaure:

With today's KDirModel improvements, it is possible for kioslaves to return non-hierarchical URL structures,
so kio_smb can use UDS_URL again instead of UDS_TARGET_URL (which wasn't good enough for treeviews, see #176555).
CCBUG: 155689


 M  +1 -6      kio_smb.cpp  
 M  +2 -2      kio_smb_browse.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=891707