Bug 155408

Don't like that. If anything embedded thumbbar should be at the bottom/top of preview area.

An additional thumbs bar definitely make sense. 
It would keep you from being thrown back to the current thumbs view which is pretty unconvenient. Instead a thumbs bar can be displayed (and used) _whilst_ a pic is selected and shown in big, side by side. 
Certainly its nice if the position can be chosen, but for the start I opt for the left side: more and more current screens come in wide format. The extra space on the side is perfect for an additional thumbs bar. Nothing is lost, much is gained in usability. 
---
arkascha

At the moment I can see 3 more or less useful possibilities:

a) The thumb bar on the left. (e.g. replacing the album list)
T iiiiii D
T iiiiii D
T iiiiii D
T iiiiii D

or beside the album view
A T iiiiii D
A T iiiiii D
A T iiiiii D
A T iiiiii D

b) The thumb bar below the picture.
A iiiiii D
A iiiiii D
A iiiiii D
A iiiiii D
A TTTTTT D

c) The thumb bar below all. (Album list and exif info will have to be 
decreased in size, when the image is displayed in full size.
A iiiiii D
A iiiiii D
A iiiiii D
A iiiiii D
TTTTTTTTTT

legend: 
A Album list
i image
D Details (e.g. exif-info)
T Thumb nails

My personal favorite would be c) But I can understand that changing the 
size of the album view and the exif info can make a mess and is maybe not 
clearly understandable for the user.

b) is maybe a not too useful, if the album view and the exif info are 
visible. Because than the thumb nail list could be rather short.

Thus I would choose a) (thumbs replacing the album view or even beside the 
album view) as well. 

Mike,

>a) The thumb bar on the left. (e.g. replacing the album list)

no. too complex and not homogenous with the rest of gui

> or beside the album view 

idem...

> b) The thumb bar below the picture. 

yes, this is the fine way

> c) The thumb bar below all. (Album list and exif info will have to be
>decreased in size, when the image is displayed in full size. 

no...

For performance reason, this can be only do with KDE4 (0.10.0) when thumbbar widget will use the multithreaded cache mechnism instead the thumbs KIO slave.

Gilles Caulier

Personally I can perfectly live with solution b). Definitely useful and usable. Anyhow, I am just a user making suggestions and looking foreward to the next release(s) of a great tool.
Cheers, Mike

Created attachment 23933 [details]
First Thumbbar for AlbumGUI (KDE4)

Hi all,

I'm working on this file currently... Some progress have be done. It's not yet 
perfect of course.

1/ The thumbbar widget used is the same than LightTable. This widget must be
re-implemented from parent thumbbar.cpp class to remove unwanted features as
options from pop-up context menu for ex.
2/ Ordering of items in thumbbar is not yet the same than IconView. 

Note: The patch is against KDE4 implementation, not KDE3.

Marcel, 

For point 2/ how do you deal to make an ordering of items accordingly with AlbumSettings::getImageSortOrder() ?

ThumbBar widget is a QScrollView, not an QIconView. We don't have a something like AlbumIconGroupItem::compare() to perform ordering...

Gilles Caulier

Created attachment 23934 [details]
Screenshot of Thumbbar embeded in albumgui

It would be easier if the ThumbbarItems were stored in a QList, so we could use Qt algorithms. It's certainly difficult to resort the custom linked-list that the items currently form.

Would using a QList still allow to tackle (at some point ;-)
Bug 91562: Change order of pictures in the virtual album manually
Bug 134389: WISH: Sort images by date - even when spanning albums
?

Arnd, this is about the ThumbBar as in the Light Table or ShowFoto only. Not about the IconView code.
The IconView code is using a similar list layout, but there with two levels of custom lists (first the group container, each containing the chain of items). These two levels make sorting as flat list difficult there.

Marcel,

I will trying to use AlbumIconView::allImageInfos() to get the list ordered from iconview directly. no need to re-invent the wheel. Using AlbumIconView::signalItemsAdded() sound fine to handle changes from icon view. 

Your viewpoint ?

Gilles

Created attachment 23939 [details]
patch revision 2

With this patch thumbbar ordering follow iconview content...

Gilles Caulier

SVN commit 787020 by cgilles:

digiKam from trunk (KDE4) : add thumbbar behind preview area from AlbumGUI when preview mode is used (F3). 
Icon view filter available to status bar and TagFilters still suitable to change thumbbar contents in live.
Thumbbar items can display Rating of pictures. More informations about thumbbar items are avaialble using 
pop-up tool tips is you enable this option in config dialog.
A fresh screenshot is available at these url :

- with Digikasa color theme : http://digikam3rdparty.free.fr/Screenshots/thumbbar4albumgui.png
- with Desert color theme : http://digikam3rdparty.free.fr/Screenshots/thumbbarwithpreviewmode.png

CCMAIL: digikam-devel@kde.org
BUG: 155408
CCBUGS: 148502



 M  +3 -5      CMakeLists.txt  
 M  +3 -5      albumiconview.cpp  
 M  +5 -2      albumiconview.h  
 M  +90 -6     albumwidgetstack.cpp  
 M  +13 -4     albumwidgetstack.h  
 M  +17 -4     digikamview.cpp  
 M  +5 -4      digikamview.h  
 AM            imagepreviewbar.cpp   [License: GPL (v2+)]
 AM            imagepreviewbar.h   [License: GPL (v2+)]
 M  +8 -8      imagepreviewview.cpp  
 M  +1 -1      imagepreviewview.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=787020