Bug 152483

Summary: Raw converted images can only be saved once
Product: [Applications] digikam Reporter: David Bremner <bremner-keyword-kde.673b66>
Component: Plugin-DImg-RAWAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: languitar, marcel.wiesweg
Priority: NOR    
Version: 0.9.3   
Target Milestone: ---   
Platform: Debian testing   
OS: Linux   
Latest Commit: Version Fixed In: 1.0.0
Sentry Crash Report:

Description David Bremner 2007-11-17 20:18:45 UTC 
Version:           0.9.3 svn (2007-11-17) (using KDE KDE 3.5.8)
Installed from:    Debian testing/unstable Packages

I am opening canon CR2 images in the image editor.
After making some changes, I save as (16bit) PNG. I then make another change, and try to resave; this brings up the same dialog, but when I click Save, the dialog goes away for a (fraction of a) second and then pops up again, without actually saving.
Comment 1 David Bremner 2007-11-17 20:19:49 UTC 
Oh, I should say that if I change the name, it saves OK, so there must be some issue with overwriting.
Comment 2 caulier.gilles 2007-11-17 20:22:56 UTC 
Yes, i can reproduce it. 

Marcel, 

it sound like a little problem in SavingContextContainer class... Right ?

Gilles
Comment 3 caulier.gilles 2008-03-18 13:58:12 UTC 
Arnd, Marcel,

Can you reproduce this problem on your computer ?

Gilles
Comment 4 Marcel Wiesweg 2008-03-18 17:56:03 UTC 
Yes I can reproduce exactly as described.
Comment 5 Andi Clemens 2009-10-08 00:28:37 UTC 
I can confirm this, it is still not working in current SVN.
One problem that might cause this: 
I have 4 RAW files loaded in the editor.
If I modify a RAW file, change some things and save it as a PNG, the status bar reads: test.png (4 of 5), although the image is listed at the end of the thumbbar.
Clicking on the original RAW file will NOT load it, so it seems to be that the editor still thinks that he has opened the RAW file, not the saved PNG file.
But the modified PNG file is clearly displayed as the currently opened image.

My guess is: the editor thinks the RAW is still opened, but displays the PNG. You manipulate the PNG even more, try to save it, but since IE thinks the RAW is opened, the save dialog appears again.
Comment 6 Andi Clemens 2009-10-15 13:11:04 UTC 
*** Bug 210659 has been marked as a duplicate of this bug. ***
Comment 7 Marcel Wiesweg 2009-10-23 18:45:42 UTC 
SVN commit 1039512 by mwiesweg:

The isReadOnly is not an attribute of the image data, but of the file the
data was originally loaded from. When saving the same data to different formats,
the original format maybe readonly and any of the saved format may be not.

Do not store this info as an integral part of the image data but only as an attribute
that can be more easily accessed from outside.

CCBUG: 152483

 M  +15 -10    dimg.cpp  
 M  +0 -2      dimg_p.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1039512
Comment 8 Marcel Wiesweg 2009-10-23 18:46:40 UTC 
SVN commit 1039513 by mwiesweg:

The method saveAsIsComplete was never called, only saveIsComplete().
Store if the save operation was save or save as, and call appropriately.
There is still some minor weirdness with the thumbbar after saving,
but nothing critical.

CCBUG: 152483

 M  +7 -1      editorwindow.cpp  
 M  +2 -2      imagewindow.cpp  
 M  +2 -0      savingcontextcontainer.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1039513
Comment 9 Marcel Wiesweg 2009-10-23 18:46:45 UTC 
SVN commit 1039514 by mwiesweg:

When saving to a new format, take over the read-only state of this file
for the current image of DImgInterface.

BUG: 152483

 M  +2 -1      NEWS  
 M  +6 -3      utilities/imageeditor/canvas/dimginterface.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1039514