| Summary: | Thumbnails are square (HTML Export tool) [patch] | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Eric Vaandering <ewv> |
| Component: | Plugin-Generic-HTMLGallery | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | caulier.gilles, jbohac, jph, michal |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 2.6.0 | |
| Sentry Crash Report: | |||
| Attachments: |
proposed patch to allow non-square thumbnails in HTML Export and enable the feature in floating_cards
refreshed patch against current git |
||
|
Description
Eric Vaandering
2007-08-27 18:42:43 UTC
Nearly two years passed and still we have square thumbnails. Croped thumbnails are actually showstopper for any serious use. And that's pity, because this plugin is very fine in other respects. I just wanted to create image gallery and send it to one magazine for selection. But with cropped thumbs it's useless. I have to look for other web gallery creation tool... I recall hearing that this would be corrected for KDE 4 - Haven't seen that it has been but then I only use KDE 4 long enough to confirm that I'm still not ready for it. That the kipi tools aren't automatically available in gwenview is one of the things that chases me away. Created attachment 66864 [details]
proposed patch to allow non-square thumbnails in HTML Export and enable the feature in floating_cards
(copied from the patch description)
HTML Export: allow non-square thumbnails
Allow the themes to specify in their desktop file that they can cope with
non-square thumbnails. The user can then choose between square and non-square
thumbnails.
Add the option to floating_cards.desktop
Jiri, Thanks for your patch. I will review it Gilles Caulier Created attachment 66886 [details]
refreshed patch against current git
Jiri, You patch work fine into "floating_cards" theme. Thumbs are sqared or not depending of option selected... But this theme sound like broken. Only one image (the first one in fact) is exported. All others do not appear in HTML page. Gilles Caulier (In reply to comment #6) Thanks for trying this out, Gilles! > But this theme sound like broken. Only one image (the first one in fact) is > exported. All others do not appear in HTML page. Strange - I am using the theme and it works fine for me. Did the theme work for you before applying this patch? Can you send me or attach the generated gallery including the gallery.xml file (you can remove the jpeg files...)? I'll have a look at it. Thanks! Jiri, Yes theme work fine without your patch. I use Chrome browser here. Gilles Caulier I retested you patch on another computer and now it work fine (:=))) It's probably a side effect with patch from bug #289283 Gilles Git commit d75ba9f099fdbd0a29c5e4baa6b803de057272bb by Gilles Caulier. Committed on 03/01/2012 at 15:40. Pushed by cgilles into branch 'master'. Apply patch #66886 from Jiri Bohac M +17 -1 htmlexport/THEME_HOWTO M +4 -0 htmlexport/htmlexportconfig.kcfg M +8 -5 htmlexport/imagegenerationfunctor.cpp M +23 -6 htmlexport/imagesettingspage.ui M +4 -0 htmlexport/theme.cpp M +1 -0 htmlexport/theme.h M +3 -0 htmlexport/themes/floating_cards/floating_cards.desktop M +5 -0 htmlexport/wizard.cpp http://commits.kde.org/kipi-plugins/d75ba9f099fdbd0a29c5e4baa6b803de057272bb |