| Summary: | [PATCH] Support for showing popfile headers in fancy headers | ||
|---|---|---|---|
| Product: | [Unmaintained] kmail | Reporter: | Sune Vuorela <debian> |
| Component: | messageviewer | Assignee: | kdepim bugs <kdepim-bugs> |
| Status: | RESOLVED WAITINGFORINFO | ||
| Severity: | wishlist | CC: | bjoern, debian, luigi.toscano, montel |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Debian testing | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | patch to add popfile headers | ||
|
Description
Sune Vuorela
2007-08-19 16:58:17 UTC
Created attachment 21432 [details]
patch to add popfile headers
Suggested patch.
Ok, some things about the patch: 1. Adding features to the 3.5 branch is no longer allowed, please port your patch to KDE 4. 2. If someone who uses popfile responses to someone who does not use it, the receiver still has the popfile headers in the mail, right? If the receiver uses KMail, he sees the popfile headers even though he does not use popfile himself, therefore I think using the existing config option is not OK. An other one has to be added. 3. Don't use tabs. Use spaces instead. 4. Please adhere to the KMail coding style, especially with regard to spaces around parenthesis. Other than that, the patch seems fine, although I haven't tried it. Can you please attach an example mail which has these headers? 1) Okay. Will do. after looking at the source, s/readBoolEntry/readEntry/ on the patch is all it seems to be required. 2) If any mailer adds random headers from the mail it replies to it is severily broken++. 3) Okay. 4) Do you have a link to the style? I have in general tried to follow the style in the file, whicgh I think I kind of succeeded. The following snippet is the headers from such mail: X-Text-Classification: ham X-POPFile-Link: http://127.0.0.1:7070/jump_to_message?view=234116 or X-Text-Classification: server_reports X-POPFile-Link: http://127.0.0.1:7070/jump_to_message?view=233811 or whatever your buckets are called. The rest of the mails is just like any other email. I unfortunately haven't got a kde4 environment running at this time, but the patch works at kde3, and the files I patch doesn't seem to have changed much. /Sune What's the status of this. Can we get a patch for KDE trunk? (based on 4.4 maybe) Status please Otherwise I will close it I haven't tested the patch in ages, and I'm not using 'popfile' any longer for spam filtering so I also don't really have the test data. Thank you for your feature request. Kmail1 is currently unmaintained so we are closing all wishes. Please feel free to reopen a feature request for Kmail2 if it has not already been implemented. Thank you for your understanding. Instead of creating a new feature request, please confirm here if the wishlist is still valid for kmail2. |