Summary: | Delete should offer the user to move the images to the trash can | ||
---|---|---|---|
Product: | [Applications] kphotoalbum | Reporter: | Jesper Pedersen <blackie> |
Component: | general | Assignee: | KPhotoAlbum Bugs <kpabugs> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | fenio |
Priority: | NOR | Keywords: | junior-jobs |
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | path to offer the user to move the images to the trash |
Description
Jesper Pedersen
2007-05-21 08:18:45 UTC
Be aware that this may take a very long time and use a lot of disk space if the images are on a different filesystem. KPA is designed to handle large numbers of very large objects; it isn't quite the same thing as deleting a few small files or files that live in your home directory. I completely agree. It should either be part of the dialog, or an option I guess. Agreed. For those who don't follow the ml, here's the thread where we already talked a lot about the delete dialog: http://mail.kdab.net/mailman/pipermail/kphotoalbum/2007-May/003262.html. In fact, I think the idea about doing as many buttons as functions it has, like KDE, gnome do when logging out is a good one. So, in this case, adding another button to move to the trashcan could be simple to do. It was not my intention to assign it to me, only to move it out of the new state The code for this is located in DeleteDialog::deleteImages (which is in MainWindow/DeleteDialog.cpp) Created attachment 37562 [details]
path to offer the user to move the images to the trash
Awesome, looks great, thanks. AS you might know KPhotoAlbum is currently in feature freeze until the release in little over a week. I'll apply the patch ones that phase is over. Rock On! Jesper. Thanks for the patch. It is applied to trunk now. Kirill. thanks for the patch, and sorry for the delay. As theBro said, its now been applied to trunk. I'd be glad if you wanted to work on more KPhotoAlbum issues. Cheers Jesper. |