Summary: | Playlist items stay greyed out even if songs are available | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | Gerrit Visscher <gerrit> |
Component: | Playlist | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | emisca |
Priority: | NOR | ||
Version: | 1.4.5 | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: |
Description
Gerrit Visscher
2007-03-27 14:58:41 UTC
My problem differs a bit from yours. I've got a encrypted disk; when i start amarok while the disk is encrypted and drag&drop some files from the collection into the playlist, the songs are greyed out and I can't play them (that's ok). But when I decrypt my partition and try to play some of the files I've just drag&dropped into the playlist, the files play fine but still are greyed out. They never get black again (using 1.4.5, this is a regression I think). SVN commit 674087 by mitchell: Do a stat on files in the playlist when loading, to make sure their status is correct when Amarok loads up. BUG: 143513 M +0 -2 playlist.cpp M +3 -8 playlistloader.cpp --- branches/stable/extragear/multimedia/amarok/src/playlist.cpp #674086:674087 @@ -3131,8 +3131,6 @@ else if ( item == currentTrack() ) attributes << "queue_index" << QString::number( 0 ); - if( !item->isFilestatusEnabled() ) - attributes << "filestatusdisabled" << "true"; if( !item->isDynamicEnabled() ) attributes << "dynamicdisabled" << "true"; --- branches/stable/extragear/multimedia/amarok/src/playlistloader.cpp #674086:674087 @@ -51,8 +51,7 @@ int queue; bool stopafter; bool dynamicdisabled; - bool filestatusdisabled; - XMLData(): queue(-1), stopafter(false), dynamicdisabled(false), filestatusdisabled(false) { } + XMLData(): queue(-1), stopafter(false), dynamicdisabled(false) { } }; class TagsEvent : public QCustomEvent { @@ -293,10 +292,8 @@ if( (*it).stopafter ) Playlist::instance()->m_stopAfterTrack = item; - if( (*it).filestatusdisabled || !( (*it).bundle.exists() ) ) - item->setFilestatusEnabled( false ); - if( (*it).dynamicdisabled ) - item->setDynamicEnabled( false ); + item->setFilestatusEnabled( (*it).bundle.exists() ); + item->setDynamicEnabled( !( (*it).dynamicdisabled ) ); } break; } @@ -500,8 +497,6 @@ data.stopafter = true; else if( atts[i].first == "dynamicdisabled" ) data.dynamicdisabled = true; - else if( atts[i].first == "filestatusdisabled" ) - data.filestatusdisabled = true; } data.bundle.checkExists(); m_xml.append( data ); *** Bug 149598 has been marked as a duplicate of this bug. *** *** Bug 149598 has been marked as a duplicate of this bug. *** Is there any way to make amarok refresh the song status when it's running? If an usb disk is unmounted when amarok starts songs in the playlist from that disk are grayed. If I mount the disk without restarting amarok, songs remain grayed until they are played. So how about a "refresh" playlist button or command? Or there is already such a command? |