Bug 139803

Summary:	[PATCH] EBN#1 - Check for TRUE and FALSE macros...
Product:	[Applications] amarok	Reporter:	Andrew Ash <ash211>
Component:	Playback	Assignee:	Amarok Bugs <amarok-bugs-null>
Status:	RESOLVED FIXED
Severity:	minor
Priority:	VHI
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Mentioned Patch

Description Andrew Ash 2007-01-09 08:31:34 UTC

Version:           svn (using KDE KDE 3.5.5)
Installed from:    Ubuntu Packages0

http://www.englishbreakfastnetwork.org/krazy/reports/extragear/multimedia/amarok/index.html

"" The TRUE and FALSE macros are obsolete and should be replaced with true and false (all lower case) respectively. ""

I wrote a script to do just that through the files mentioned on EBN.  The helix engine code had most of these cases and I'm using xine, so I haven't tested that portion of the code.  Amarok compiles and runs just fine with the changes made.

amarok/src/engine/helix/helix-sp/helix-include/common/include/hxtypes.h
Check the preprocessor definitions in this file.  I think they can be safely removed now that macros aren't being used for true and false.


Andrew Ash

Comment 1 Andrew Ash 2007-01-09 08:32:37 UTC

Created attachment 19205 [details]
Mentioned Patch

against current svn 621579

Comment 2 Edward Hades 2008-06-16 14:20:32 UTC

*** Bug has been marked as fixed ***.