Bug 137282

Summary:	Comments are lost when copying or moving a picture to another album
Product:	[Applications] digikam	Reporter:	Fabien <fabien.ubuntu>
Component:	DImg-FileIO	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED WORKSFORME
Severity:	normal	CC:	caulier.gilles
Priority:	VHI
Version:	unspecified
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed In:	0.9.0
Sentry Crash Report:

Description Fabien 2006-11-13 12:54:48 UTC

Version:           0.9-svn (using KDE KDE 3.5.2)
Installed from:    Ubuntu Packages
OS:                Linux

If you try to copy or move a picture to another album, comments are lost.

This only happens if "Save image comments as embedded text" is not active in 
digikam settings (Metadata section).

Comment 1 caulier.gilles 2006-11-13 19:01:20 UTC

This problem must be fixed before 0.9.0-final release 
 
Gilles Caulier

Comment 2 Marcel Wiesweg 2006-11-14 20:19:17 UTC

DIO::copy is invoked correctly with digikamalbums:// URLs. The question is, why is the ioslave's copy method not invoked?

Comment 3 caulier.gilles 2006-11-14 20:39:07 UTC

I can confirm this problem on my computers.

Gilles

Comment 4 Marcel Wiesweg 2006-11-15 17:38:45 UTC

This is the problem:
If we specify KIO::UDS_LOCAL_PATH in kio_digikamalbums::createUDSEntry, KIO::CopyJob will use the local paths instead, bypassing the copy method builtin in the ioslave.
Specifying KIO::UDS_LOCAL_PATH was added to fix the "Picture is not stored on the local host. Click to load" message in the "File already exists" dialog, fixing a bug report.
(this only applies for KDE >3.4)

Shall we revert the fix for the minor bug, to fix the major bug for the 0.9 release?

Comment 5 caulier.gilles 2006-11-15 18:09:54 UTC

yes Marcel, and re-open the file in B.K.O with this explanations util we find an alternative solution.

Gilles

Comment 6 Marcel Wiesweg 2006-11-15 19:05:51 UTC

SVN commit 605173 by mwiesweg:

Revert fix for bug #122653, as a temporary fix for bug #137282

CCBUG: 137282, 122653


 M  +7 -0      digikamalbums.cpp  


--- trunk/extragear/graphics/digikam/kioslave/digikamalbums.cpp #605172:605173
@@ -1151,11 +1151,18 @@
     atom.m_str = QFileInfo(path).fileName();
     entry.append(atom);
 
+    /*
+    // If we provide the local path, a KIO::CopyJob will optimize away
+    // the use of our custom digikamalbums:/ ioslave, which breaks
+    // copying the database entry:
+    // Disabling this as a temporary solution for bug #137282
+    // This code is intended as a fix for bug #122653.
 #if KDE_IS_VERSION(3,4,0)
     atom.m_uds = KIO::UDS_LOCAL_PATH;
     atom.m_str = path;
     entry.append(atom);
 #endif
+    */
 
     return true;
 }

Comment 7 Fabien 2006-11-17 15:59:29 UTC

I tested it, it's ok. I close the bug.