Version: 0.9-svn (using KDE KDE 3.5.2) Installed from: Ubuntu Packages OS: Linux If you try to copy or move a picture to another album, comments are lost. This only happens if "Save image comments as embedded text" is not active in digikam settings (Metadata section).
This problem must be fixed before 0.9.0-final release Gilles Caulier
DIO::copy is invoked correctly with digikamalbums:// URLs. The question is, why is the ioslave's copy method not invoked?
I can confirm this problem on my computers. Gilles
This is the problem: If we specify KIO::UDS_LOCAL_PATH in kio_digikamalbums::createUDSEntry, KIO::CopyJob will use the local paths instead, bypassing the copy method builtin in the ioslave. Specifying KIO::UDS_LOCAL_PATH was added to fix the "Picture is not stored on the local host. Click to load" message in the "File already exists" dialog, fixing a bug report. (this only applies for KDE >3.4) Shall we revert the fix for the minor bug, to fix the major bug for the 0.9 release?
yes Marcel, and re-open the file in B.K.O with this explanations util we find an alternative solution. Gilles
SVN commit 605173 by mwiesweg: Revert fix for bug #122653, as a temporary fix for bug #137282 CCBUG: 137282, 122653 M +7 -0 digikamalbums.cpp --- trunk/extragear/graphics/digikam/kioslave/digikamalbums.cpp #605172:605173 @@ -1151,11 +1151,18 @@ atom.m_str = QFileInfo(path).fileName(); entry.append(atom); + /* + // If we provide the local path, a KIO::CopyJob will optimize away + // the use of our custom digikamalbums:/ ioslave, which breaks + // copying the database entry: + // Disabling this as a temporary solution for bug #137282 + // This code is intended as a fix for bug #122653. #if KDE_IS_VERSION(3,4,0) atom.m_uds = KIO::UDS_LOCAL_PATH; atom.m_str = path; entry.append(atom); #endif + */ return true; }
I tested it, it's ok. I close the bug.