| Summary: | Broken "Open File" dialog in Color Management tool | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Dik Takken <kde> |
| Component: | ColorManagement-Views | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles |
| Priority: | NOR | ||
| Version: | 0.9.0 | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 1.0.0 | |
| Sentry Crash Report: | |||
| Attachments: |
File dialog in Color Management Plugin
patch to use QScrollArea to host icc profile preview widget |
||
|
Description
Dik Takken
2006-08-06 12:11:48 UTC
I cannot reproduce this problem here. Can you give us a screenshot please ? Gilles Caulier This happen in other kde apps too, i think you can solve it if you adjust the dialog size using the mouse. Paco. Hmm. I never noticed the problem in other KDE apps. Resizing does not trigger the appearance of a scrollbar, unless I make it really big, to make the preview fully visible. Only then, a horizontal scrollbar appears. Created attachment 17419 [details]
File dialog in Color Management Plugin
Same here. I see two possibilities: Either there is a problem with size hints or minimum size or whatever in the embedded widget. Or the file open dialog assumes that widgets are small enough and does not create scrollbars if not. Perhaps then we need to embed the embedded widget in another widget that provides scrollbars. El S Paco, this is my viewpoint : Like the icc preview widget is embedded by the KFileDialog, this is the role to this dialog to respect the widget size to render properly to the screen (to provide a scroolbar in fact). I suspect a problem in KFileDialog layout management, especially in the preview area. Of course, perhaps something can be done in digiKam to solve the problem like Marcel has said. I recommend you to check the KDELibs library implementation to find a part using a KFileDialog instance with a preview widget, and look how the preview widget is embedded into the KFileDialog. Gilles This is still present in latest KDE4... I will take a look at this today. Andi We should either use a ScrollArea widget here (or similar) or write a different ICCProfile preview widget. I think the current one is MUCH to big for a preview widget in an open file dialog. In general it would be nice if graphic widgets (like ICCProfile, CurvesWidget, Histogram etc) would scale down automatically, this will solve a lot of space problems. Right now they are all fixed size. Andi Using QScrollArea Will be the speed way to fix this entry. I will do it Trying to redesign ICC profile widget will be a lot's of job. It's will be better to see if lprof project now share this widget in a library. Current implementation use this code plus customizations, redesign and several improvements. Gilles Caulier Created attachment 29222 [details]
patch to use QScrollArea to host icc profile preview widget
Marcel, Andi,
Using QScrollArea do not solve this problem. Try my patch attached
Gilles
No, doesn't work good... ;-( SVN commit 925544 by aclemens: Use QScrollArea for ICCPreviewWidget, do not use setWidgetResizable(), otherwise the preview widget becomes messed up. Right now this seems to be the best solution, what do you think? It scales vertically, but not horizontally. I think it still looks ok. CCBUG:131948 M +8 -4 iccpreviewwidget.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=925544 It's better and fine for me... Gilles Any idea how we can make it expand only horizontally? I tried using the "Horizontal Policy", but this seems to be ignored when a layout is used. I set vertical: Fixed horizontal: MinimumExpanding Maybe I did something wrong? I'll try it once again... Andi Can we close this one? The old color management plugin is gone and therefore the problem described in here, right? Andi I will close this one now, since we don't seem to use IICProofTool anymore. |