| Summary: | wrong date in header using date-view | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Erwin Bauer <erwin.bauer> |
| Component: | Searches-Dates | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles, mcguire |
| Priority: | NOR | ||
| Version: | 0.8.2 | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 7.0.0 | |
| Sentry Crash Report: | |||
| Attachments: | described problem | ||
|
Description
Erwin Bauer
2006-07-04 01:59:15 UTC
Erwin, What's news about this report. It still valid using digiKam 0.9.4 or 0.10.0 ? Gilles Caulier No response... Andi, Marcel, Arnd, Mik, it still valid with 0.10.0 ? If no, we can close it... Gilles Caulier SVN commit 893026 by aclemens: fix album headers: it displayed "MONTH 2,008" instead of "MONTH 2008" CCBUG:130230 M +1 -1 albumicongroupitem.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=893026 > What's news about this report. It still valid using digiKam 0.9.4 or 0.10.0 ?
It is still valid with 0.10.0 beta7.
Finally! I can close something as fixed ;) ? It is not fixed yet... I guess this bugreport is the same as this one: http://bugs.kde.org/show_bug.cgi?id=156599 Andi Created attachment 29572 [details]
described problem
I don't really know what to do with this bugreport. For me it is not a bug, because the date you see in the album header is the date of the album, not the one of the current view.
One simple solution for me would be to just don't display the album date at all in this view.
Gilles, Marcel, Arnd,
what do you think about this report?
Andi
Andi, My proposal: change text in album header like this : "My Album Created at December 2008 - 1 item" The "Created at" prefix is explicit : it's creation date of album, not a synthesis of dates taken from album contents. It's simple and fast... Gilles Caulier Yes, sound good. I'll check that... Andi SVN commit 900563 by aclemens: be more verbose in album header label: use "Created on" prefix to reduce confusion when displaying images in date view. CCBUG:130230 M +1 -1 albumicongroupitem.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=900563 Ok, done. I will not close this one because we might need other opinions here? For me it is ok... +1 for the prefix :-) Andi In the long run, I think the best way to fix this is to implement bug 134389 (ability to hide album headers and sort the images without taking album borders into account). This way, for the date view, we could by default hide album headers, and this problem wouldn't be there. >In the long run, I think the best way to fix this is to implement bug 134389 I'm agree. > This way, for the date view, we could by default hide album headers, and this > problem wouldn't be there. I'm not agree. Hiding album header will introduce new bug report. Gilles Caulier Ad #c13: but then the problem is only hidden (and I really would like to have the merged view, but as something which can be changed by the user, because the separation by folders is also useful in several other situations). I am not sure, whether the "Created on" is the right solution: the album date can be: - an average of all images - the date of the first image - a date, specified by the user So I think that: "Album date: ...." would better describe its meaning as it not necessarily reflects the creation date (which is pretty irrelevant for an album IMO). (Actually, I would prefer, that the Album date also includes the day and not just month/year) Maybe we should use the shortform of the month then, because it gets really long: /My Albums/Test01 Album Date: 12 Dec 2008, 100 items For me adding more descriptive header is enough. Also +1 for shortening of month. Not because of length but due to nature of some languages. For example in Polish when using whole name you should change case depending on context, eg. proper translation should be: Album date: 12 December 2008 -> Data albumu: 12 grudnia 2008 ------------------------------------------------^^^^^^^ Gettext mechanism doesn't allow for that and it will insert only "12 grudzien 2008" which is awkward (although not ungrammatical). With shortening of month name we (in Poland) will get: "12 Gru 2008" which is completely neutral. Ok patch would be ready... waiting for more comments here... Andi I will commit this patch now, if someone doesn't like it, we can change it again :-) SVN commit 903229 by aclemens: using "Album Date:" with the shortened month name in album header as suggested in bug 130230 CCBUG:130230 M +7 -4 albumicongroupitem.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=903229 Andi, This file is fixed now ? Gilles Caulier If everybody is happy with the current solution, it could be closed. But I didn't got response so far. Andi For me it's fine Gilles What about the original post? I think it is invalid. If nobody is commenting on this anymore, I will close the file today... Andi Agree for me Gilles I will close it now, if more discussion is needed, feel free to re-open it again. Andi Not reproducible with 7.0.0-beta1 |