| Summary: | random album mode acts funny when albumless tracks are played | ||
|---|---|---|---|
| Product: | [Applications] amarok | Reporter: | Simon80 |
| Component: | general | Assignee: | Amarok Bugs <amarok-bugs-null> |
| Status: | RESOLVED UNMAINTAINED | ||
| Severity: | normal | CC: | edward.hades, jed-kdebugzilla, kde, myriam, phil, ron.eggler |
| Priority: | NOR | ||
| Version First Reported In: | 1.4.5 | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: | Adds indexInAlbum to class PlaylistItem to prevent track scrolling. | ||
|
Description
Simon80
2006-06-01 03:14:06 UTC
I can confirm this bug in 1.4.3. If Amarok stumbles upon >1 albumless tracks by the same artist in random album order, it will keep looping over those tracks forever. *** Bug 132895 has been marked as a duplicate of this bug. *** See 132895 for a bit more analysis and a possible patch. I think the same happens when the album has no track numbers Actually, it happens not when the album string is empty, but when the tracks have no tracknumbers. You can confirm this by printing the current album list in playNextTrack(), which will show something like this:
1. track1-title
2. track2-title
3. track3-title
4. track4-title
then if you wait for about 5 secs before pressing "Next", or waiting for the whole track to finish playing, you'll get:
1. track2-title
2. track3-title
3. track4-title
4. track1-title
and so on. This means that: The tracks _scroll_ and amaroK perpetually thinks it's playing the 1st track on the album, so it just loops there. The scrolling is caused by the code
m_album->tracks.removeRef( this );
in decrementTotals(), and then
m_album->tracks.append( this );
in incrementTotals().
But if you quickly & repeatedly press the "Next" button, amaroK will go through the album just as expected. I'm not sure, but I think this is because there's not been enough time for the track to get removed from the list and then added again, as in decrementTotals() and incrementTotals().
Anyway, I have a fix now. This is a kludge, but since I'm not that familiar with amaroK, I hope the developers would try to find another way to fix it (if my patch is considered good then please accept it ^_^)
Created attachment 18004 [details]
Adds indexInAlbum to class PlaylistItem to prevent track scrolling.
This is a kludge, but at least it works.
*** Bug 138656 has been marked as a duplicate of this bug. *** confirm this bug in 1.4-SVN-0611301953. it's time for this patch(or anoth one) find its way in the Amarok code, isn't it? *Patch not applied yet* Just wanted to remind you guys of this one, looking at the dates it seems to have escaped your attention. Yeah, this bug is still in the latest SVN. It annoys me to no end because I have a lot of mp3s from http://ocremix.org (which also happens to be their album name) but with no track numbers, of course. Every time random album mode hits one of those it gets stuck in a cycle. We are sorry, but Amarok 1.x is not maintained anymore |