| Summary: | Free/Busy information not renerated for recurring events with end date after fb-period | ||
|---|---|---|---|
| Product: | [Applications] korganizer | Reporter: | Philipp Hahn <pmhahn+kde> |
| Component: | general | Assignee: | kdepim bugs <kdepim-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Debian testing | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
Source Calendar
Generated free/busy information Small test program to show bug Fix RecurrenceRule::endDt() Fix CalendarLocal::rawEvents updated patch for CalendarLocal::rawEvents |
||
|
Description
Philipp Hahn
2006-03-29 15:03:38 UTC
Created attachment 15349 [details]
Source Calendar
A sample calendar with three recurring events which recurr until dates spaced
one month after each other.
Created attachment 15350 [details]
Generated free/busy information
Generated free/busy information from calendar with three recurring events which
recurr until dates spaces one month after each other.
Entries for Event C 'FREEBUSY:2006....T130000Z/2006....T140000Z' are missing.
Created attachment 15369 [details]
Small test program to show bug
This small program creates a calendar which shows the bug. Put it in
kdepim/libkcal/tests, add it to Makefile.am the same as the "readandwrite"
test, compile and run it.
The generated free/busy-information only includes event 'A' but not 'B'.
One more comment: The recurring event must start before the FB-interval and must run until after the FB-interval to show the bug. If the event first starts inside the FB-interval, is shows correctly. Created attachment 15374 [details]
Fix RecurrenceRule::endDt()
* Fix assignment of boolen value to pointer to boolean
* Actually also asign true some times
Created attachment 15375 [details]
Fix CalendarLocal::rawEvents
Rewrite the whole function from if^5-nesting to something more human
understandable.
This fixes the generation of my Free/Busy-Information but needs to be checked
for other users.
Reassigning all KOrganizer bug reports and wishes to the newly created korganizer-devel mailing list. Created attachment 21726 [details] updated patch for CalendarLocal::rawEvents I can confirm that this bug still exists in 3.5.7. Philipp's patches from #5 and #6 seem to fix it. The changes from r614014 of December 16 2006 (see http://websvn.kde.org/?view=rev&revision=614014) require one line in the second patch to be changed to make it apply cleanly. I've attached the corrected patch. Note that this bug's impact is more than just cosmetic: It breaks the export of free/busy information for many recurring events and makes the KOrganizer user look unprofessional. Since the bug can be fixed by applying these two small patches, this should definitely be something to be fixed in KDE 4.0. SVN commit 719675 by winterz: Fix bug "Free/Busy information not renerated for recurring events with end date after fb-period" Thanks to the patches and test progam from Philipp and the extra testing by Tim. BUGS: 124495 M +61 -48 calendarlocal.cpp M +10 -16 recurrencerule.cpp M +7 -2 tests/Makefile.am A tests/fbrecurring.cpp [License: no copyright] WebSVN link: http://websvn.kde.org/?view=rev&revision=719675 |