Bug 122356

Summary:	Don't create different accesskeys for the same URL
Product:	[Applications] konqueror	Reporter:	Rolf Eike Beer <kde>
Component:	general	Assignee:	Konqueror Developers <konq-bugs>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	bugzilla, finex
Priority:	NOR
Version:	SVN
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Untested try to ignore duplicate URLs

Description Rolf Eike Beer 2006-02-20 17:41:04 UTC

Version:           3.5 (using KDE 3.5.0 Level "a" , SUSE 9.3 UNSUPPORTED)
Compiler:          gcc version 3.3.5 20050117 (prerelease) (SUSE Linux)
OS:                Linux (i686) release 2.6.11.4-21.10-smp

When a URI is linked multiple times khtml assignes the same accesskey to the same URI. But when one of this URIs has a accesskey assigned with <a accesskey="... > a different key is used for this URI with and without specified accesskey.

Example:

<li><a href="foo.html" accesskey="f">foo</a></li>
<li><a href="foo.html">foo</a></li>

will result in 2 different accesskeys (normally 'f' and 'o').

Whishlist: don't do that. First check if there is a 'hardcoded' accesskey for this URI already.

Comment 1 kavol 2007-03-04 00:32:14 UTC

I just run into something similar ... in my case, I have explicitly set the same accesskey for the same href targets but only the first one is being displayed after hitting the Ctrl key (the second one does not display any accesskey at all).

- I guess if such behaviour has something to do with bug 121144 but it seems that the patch deals with javascript only while I have static links?

using Konqueror 3.5.6

Comment 2 Rolf Eike Beer 2009-12-25 20:09:16 UTC

Created attachment 39337 [details]
Untested try to ignore duplicate URLs

The basic idea behind this patch is that all URLs that already have an accesskey manually assigned will be ignored when the remaining URLs will get the remaining keys assigned. It's ownly compile tested.

If this is acceptable please tell me when I should commit this.

Comment 3 FiNeX 2010-08-23 22:09:39 UTC

@Rolf: you should post the patch in the KDE reviewboard.

http://techbase.kde.org/Contribute/Send_Patches
http://reviewboard.kde.org/

Comment 4 Rolf Eike Beer 2010-09-12 19:01:05 UTC

SVN commit 1174506 by dakon:

avoid duplicate accesskeys for the same URL

BUG:122356
REVIEW:5134


 M  +14 -4     khtmlview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1174506

Comment 5 Thiago Macieira 2010-09-29 11:07:26 UTC

SVN commit 1180870 by thiago:

Revert commit 1174506 "avoid duplicate accesskeys for the same URL"

This introduced an infinite loop in the access-key resolution. Go to a
bugzilla bug comment and press Ctrl -- konq locks up due to the
infinite loop.

CCBUG:122356

 M  +4 -14     khtmlview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1180870

Comment 6 Rolf Eike Beer 2010-10-06 20:28:15 UTC

SVN commit 1183254 by dakon:

avoid duplicate accesskeys for the same URL, this time without endless loop

CCBUG:122356


 M  +16 -4     khtmlview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1183254