Summary: | Google Video problem seeing bar | ||
---|---|---|---|
Product: | [Applications] konqueror | Reporter: | Jordi Pina <pinucset> |
Component: | khtml | Assignee: | Konqueror Developers <konq-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | thiago |
Priority: | NOR | ||
Version: | 3.5 | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: |
Description
Jordi Pina
2005-12-03 17:58:05 UTC
Confirmed. This is caused by the fact that we try to load a VBScript and we shouldn't. We have a patch for this, but it needs some testing. This happen also to me with KDE 3.5.2 from SVN and qt 3.3.6 This works here (if there are no javascript errors preventing the movie to play) Using kde 3.5.4 SVN commit 589919 by orlovich: - Make sure we always size the plugin: - Fixes google videos showing up. - Fixes acroread in background tab. - Make sure to notify the plugin directly of size changes: - Fixes resizing of google videos - Makes sizing of acroread more reliable BUG:117603 BUG:125076 BUG:118038 ... And potentially a couple others, will double-check. M +5 -0 nspluginloader.cpp M +1 -0 nspluginloader.h M +1 -5 viewer/nsplugin.cpp M +0 -1 viewer/nsplugin.h --- branches/KDE/3.5/kdebase/nsplugins/nspluginloader.cpp #589918:589919 @@ -120,6 +120,11 @@ kdDebug() << "NSPluginInstance(client)::resizeEvent" << endl; } +void NSPluginInstance::showEvent(QShowEvent *event) +{ + EMBEDCLASS::showEvent(event); + resizePlugin(width(), height()); +} /*******************************************************************************/ --- branches/KDE/3.5/kdebase/nsplugins/nspluginloader.h #589918:589919 @@ -56,6 +56,7 @@ protected: void resizeEvent(QResizeEvent *event); + void showEvent (QShowEvent *); void windowChanged(WId w); class NSPluginLoader *_loader; bool shown; --- branches/KDE/3.5/kdebase/nsplugins/viewer/nsplugin.cpp #589918:589919 @@ -588,7 +588,6 @@ : DCOPObject(), QObject( parent, name ) { Q_UNUSED(embed); - _firstResize = true; _visible = false; _npp = privateData; _npp->ndata = this; @@ -988,10 +987,7 @@ resizeWidgets(XtWindow(_form), _width, _height); - if (_firstResize) { - _firstResize = false; - setWindow(); - } + setWindow(); kdDebug(1431) << "<- NSPluginInstance::resizePlugin" << endl; } --- branches/KDE/3.5/kdebase/nsplugins/viewer/nsplugin.h #589918:589919 @@ -220,7 +220,6 @@ bool _destroyed; bool _visible; - bool _firstResize; void addTempFile(KTempFile *tmpFile); QPtrList<KTempFile> _tempFiles; NSPluginCallbackIface_stub *_callback; |