Bug 113808

Summary: Tags view: can not change the tag icon with the contextual menu "Edit Tag Properties..." after setting a photo as tag thumbnail.
Product: [Applications] digikam Reporter: Tung NGUYEN <ntung>
Component: Usability-MenusAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles
Priority: NOR    
Version: 0.8.0   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed In: 8.4.0
Sentry Crash Report:

Description Tung NGUYEN 2005-10-03 22:11:58 UTC 
Version:           0.8.0-beta2 (using KDE KDE 3.4.2)
Installed from:    Compiled From Sources
OS:                Linux

For exemple:
- In the Tags view, set a Photo1 as a Tag1 thumbnail.
- Now, select Tag1 and "Edit Tag Properties..." it.
- Click on the icon button and select a different icon.
- Click on OK to accept the Tag1 edition.

=> nothing happens, Tag1 keeps always the Photo1 icon (even after DigiKam restart).
Comment 1 Renchi Raju 2005-10-04 10:07:02 UTC 
SVN commit 467063 by pahlibar:

kde > 3.3.x allows us to lock out the "other" icon select
option. use it. 

Its no longer possible in 0.8.x to set icons through the 
kicondialog. use the assign tag thumbnail or drag-and-drop
a file to assign thumbnail

BUGS: 113808


 M  +15 -0     tagcreatedlg.cpp  


--- trunk/extragear/graphics/digikam/digikam/tagcreatedlg.cpp #467062:467063
@@ -21,6 +21,7 @@
 #include <klocale.h>
 #include <kicondialog.h>
 #include <kapplication.h>
+#include <kdeversion.h>
 
 #include <qcombobox.h>
 #include <qlabel.h>
@@ -113,9 +114,16 @@
 
 void TagCreateDlg::slotIconChange()
 {
+#if KDE_IS_VERSION(3,3,0)
+    KIconDialog dlg(this);
+    dlg.setup(KIcon::NoGroup, KIcon::Application, false, 20, false,
+              true, true);
+    QString icon = dlg.openDialog();
+#else
     QString icon = KIconDialog::getIcon(KIcon::NoGroup, KIcon::Application, false, 20);
     if (icon.startsWith("/"))
         return;
+#endif
 
     if (icon.isEmpty() || m_icon == icon)
         return;
@@ -221,9 +229,16 @@
 
 void TagEditDlg::slotIconChange()
 {
+#if KDE_IS_VERSION(3,3,0)
+    KIconDialog dlg(this);
+    dlg.setup(KIcon::NoGroup, KIcon::Application, false, 20, false,
+              true, true);
+    QString icon = dlg.openDialog();
+#else
     QString icon = KIconDialog::getIcon(KIcon::NoGroup, KIcon::Application, false, 20);
     if (icon.startsWith("/"))
         return;
+#endif
     
     if (icon.isEmpty() || icon == m_icon)
         return;