Bug 108748

Summary: icons scale up when they can scale down
Product: [Unmaintained] kdelibs Reporter: Jonathan Riddell <jr>
Component: generalAssignee: Antonio Larrosa <larrosa>
Status: RESOLVED DUPLICATE    
Severity: normal    
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Jonathan Riddell 2005-07-08 12:11:48 UTC
Version:            (using KDE KDE 3.4.1)
Installed from:    Compiled From Sources

When asking for an icon which isn't available in the required size kicontheme will sometimes choose a smaller one and scale up instead of a larger one scaling down.  Very noticable when setting MenuEntryHeight=22 in kickerrc.

This patch fixes but may not be the most efficient fix.

--- kdelibs/kdecore/kicontheme.cpp	2005-07-04 15:15:19.000000000 +0000
+++ kdelibs/kdecore/kicontheme.cpp	2005-07-04 16:05:36.130701072 +0000
@@ -390,7 +390,7 @@
              it's a downscale, and we only had upscales befores.
              This is to avoid scaling up unless we have to,
              since that looks very ugly */
-          if ((abs(dw) >= abs(delta)) ||
+          if (/*(abs(dw) >= abs(delta)) ||*/
               (delta > 0 && dw < 0))
             continue;
         }
Comment 1 Christoph Feck 2009-06-21 01:41:43 UTC

*** This bug has been marked as a duplicate of bug 142744 ***