Bug 106578

Summary:	[icq] html entities used when not necessary
Product:	[Unmaintained] kopete	Reporter:	Mathias Wennberg <spyfrog>
Component:	ICQ and AIM Plugins	Assignee:	Kopete Developers <kopete-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	dominik.karall, meyerm, mschiff, sven.burmeister, vesned
Priority:	NOR
Version:	0.10.2
Target Milestone:	---
Platform:	openSUSE
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Mathias Wennberg 2005-06-01 00:22:34 UTC

Version:           0.10.2 (using KDE KDE 3.4.0)
Installed from:    SuSE RPMs
OS:                Linux

When sending messages to ICQ 2001b (and possibly other ICQ clients) on Windows (swedish), kopete adds <br> in the message instead of a row break.
This result in ICQ showing <br> instead of a line break.

Loaded modules:
connection status
contact notes
cryptography (but not used in this messages)
history
netmeeting
statistics
suse smppd-en

How to reproduce:
Send a message to an Windows ICQ client containing a line break (newline).

Comment 1 Silas De Munck 2005-06-01 00:32:02 UTC

It also sends &gt; and &lt; instead of > and <.

Comment 2 Jan Ritzerfeld 2005-06-01 01:13:28 UTC

Linebreak works for me in svn trunk and miranda/licq on the other side.
BTW, isn't that a duplicate of Bug 102880?

Comment 3 Matt Rogers 2005-06-02 05:13:16 UTC

*** Bug 106637 has been marked as a duplicate of this bug. ***

Comment 4 Ken Zalewski 2005-06-02 16:18:06 UTC

Just a bit more on this problem:

The following characters are getting translated on outgoing ICQ messages:

Two consecutive spaces ("  ") ==> "&nbsp; "
Ampersand ("&") ==> "&amp;"
Less-than ("<") ==> "&lt;"
Greater-than (">") ==> "&gt;"
Newline ==> "<br />"

Is there a simple way for users to patch this immediately?

Comment 5 Jan Ritzerfeld 2005-06-08 18:51:58 UTC

*** Bug 107049 has been marked as a duplicate of this bug. ***

Comment 6 Olivier Goffart 2005-06-20 09:09:16 UTC

*** Bug 107763 has been marked as a duplicate of this bug. ***

Comment 7 meyerm 2005-07-05 12:06:06 UTC

When sending messages between two Kopete 0.10.2 the problem also appears. Sending tags results in escaped HTML code on the receiver side, sending already escaped code results in the sended text. But the biggest problem (which makes my chat partners angry ;-) ) is when I simply send normal text with newlines etc. they are send as HTML tags...

Comment 8 Matt Rogers 2005-07-07 05:58:06 UTC

Fixed for KDE 3.4.2 (Kopete 0.10.3)

Comment 9 Ken Zalewski 2005-07-07 18:06:11 UTC

Can you provide a patch, or a list of files that we can retrieve from CVS in order to patch 0.10.2 prior to the KDE 3.4.2 release?

Comment 10 Ken Zalewski 2005-07-08 21:32:59 UTC

Strike my last comment.  I downloaded the latest Kopete 0.10.3 from SVN using the instructions for Stable Checkout from SVN.

I then replaced the kopete/ directory in the sources for kdenetwork-3.4.1 with
this new version of Kopete, and rebuilt.

Kopete 0.10.3 is now running nicely on my KDE 3.4.1 desktop.

The HTML tag/entity issue seems to be resolved.

The as-you-type spell checking seems a bit weird.  It is enabled, then it gets disabled after typing the first word.

Comment 11 Matt Rogers 2005-07-08 22:28:03 UTC

that is due to the way it is designed. the highlighting is turned off if you misspell too many words. Once the ratio of mispelled words to correctly spelled words goes down, the highlighting reappears. Kopete from SVN trunk has better indications regarding the status of the spell checking

Comment 12 Olivier Goffart 2005-07-15 10:19:54 UTC

still not fixed in svn version

Comment 13 Olivier Goffart 2005-07-15 10:26:50 UTC

*** Bug 109103 has been marked as a duplicate of this bug. ***

Comment 14 Olivier Goffart 2005-07-15 10:44:44 UTC

Sorry, i was beleiving i was using the svn version, but iwas using the release.
the svn version works fine.