| Summary: | auto-reconnect on protocol error | ||
|---|---|---|---|
| Product: | [Unmaintained] kopete | Reporter: | Quinn Storm <livinglatexkali> |
| Component: | general | Assignee: | Kopete Developers <kopete-bugs-null> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | wishlist | ||
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
patch to oscar protocol to enable reconnecting & to switch KMessageBoxes to KPassivePopups
Went over the jabber code, this is a cumulative patch of the oscar one and one for the jabber code. |
||
|
Description
Quinn Storm
2005-05-26 01:58:35 UTC
Created attachment 11205 [details]
patch to oscar protocol to enable reconnecting & to switch KMessageBoxes to KPassivePopups
Obviously this is a hack, really doing this right will need a few things,
including fixing kopete to have a centralized error reporting system (or so it
seems, other options may exist, I'm not a core dev)
Created attachment 11206 [details]
Went over the jabber code, this is a cumulative patch of the oscar one and one for the jabber code.
enables auto-reconnecting and uses KPassivePopups for oscar & jabber, I hope
You have to make absolutely sure that the code works correctly in all cases. Especially the Jabber plugin is tricky because it has tons of different disconnection reasons. Either way, the use of KPassivePopups is dangerous because they only work when you can be really certain that the next reconnection attempt succeeds. If the server is not available and you keep attempting to reconnect, you spam the user's desktop. The lines about the bad password in the Jabber plugin are good catches though, I'll apply them. Please keep two separate patches for the protocols since right now I am restructuring the code and am unable to merge the patch as it is. There's no particular need to merge these patches now, they are indeed hackish and I understand that, so I don't expect them to get merged yet. to reply to the desktop flooding problem, as I already mentioned on #kopete, kpassivepopups as I used time out automatically & don't stack up, thats their purpose ^-^ and why I switched to them instead of kmessagebox. however, this code is hackish and will be dropped for the centralized error system that is being developed for libkopete anyway Hi Till, Are you working on the reconnect feature or do you want a patch? (note; I'm not able to create one). *** This bug has been confirmed by popular vote. *** |