| Summary: | navigation between patches for different files should be possible when embedding the part | ||
|---|---|---|---|
| Product: | [Applications] kompare | Reporter: | Leo Savernik <l.savernik> |
| Component: | general | Assignee: | Kompare developers <kompare-devel> |
| Status: | CONFIRMED --- | ||
| Severity: | wishlist | CC: | bruggie, esigra, poletti.marco, rasasi78, toralf.foerster |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Leo Savernik
2005-04-27 17:12:02 UTC
Naah, Ark doesn't contain a built-in diff viewer; it simply asks KTrader for something that can handle "text/x-diff". So the wish is actually to have the kompare-part handle the navigation between the patches for different files itself (or embed the navigation part itself) rather than letting the kompare-shell handle that, so that kompare-part is more useful when embedded in Konqueror or Ark. Right, ARK then also need to ask for the navigation widget ut that is too hard. I will start a rewrite of certain things for 4.0 if I can find the time to make this a bit better or autoload the navigationpart in the komparepart itself. I dont know how else to fix this. This is gonna be a little spammy... I'm reassigning everything that's currently assigned to bruggie (who's been the default assignee for bugs since time began) to the new list address. Bruggie: if you're working on one or more of these atm, please snatch 'em back.. Everyone, esp. Joshua and Bruggie: if this genrates 33 mails, my sincere apologies.. SVN commit 443929 by je4d: Add a new directory view, based on newly abstracted komparelistview :-) GUI FEATURE The navigation is entirely contained in KomparePart now, so when this is merged into HEAD 104660 will be fixed. CCBUG: 104660 M +6 -0 Makefile.am M +4 -2 kompare_part.cpp M +21 -4 kompareconnectwidget.cpp M +3 -0 kompareconnectwidget.h A komparedirlistview.cpp [License: GPL (v2+)] A komparedirlistview.h [License: GPL (v2+)] A komparedirsplitter.cpp [License: GPL (v2+)] A komparedirsplitter.h [License: GPL (v2+)] A komparedirstyle.cpp [License: no copyright] A komparedirstyle.h [License: no copyright] M +11 -1 komparefilelistview.cpp M +4 -0 komparefilelistview.h M +83 -16 komparelistview.cpp M +19 -4 komparelistview.h M +23 -2 komparenavframe.cpp M +10 -1 komparenavframe.h Is it supposed to be already fixed in kde 3.5.8? I can't see it working. Thanks. That's a 3-way-kompare branch commit, unfortunately that branch is still not ready for production use. *** Bug 128082 has been marked as a duplicate of this bug. *** Pressing Ctrl+PageUp and Ctrl+PageDown will make kompare go through the files in the diff. I know it is now a solution and only a workaround but it should be enough to get everyone to sto pfiling bugs :-). Maybe we can add a variable to the kompare part that get initialized from kompare's main function when the navigation part is available. If not it is not initialized or set to false and we show a popup that tells the user he can use these keystrokes to navigate between files in a widget. I think that is the best solution for now until we're finally embedding the navigation into the view part. *** Bug 259411 has been marked as a duplicate of this bug. *** *** Bug 269415 has been marked as a duplicate of this bug. *** |