Summary: | receiving breaks for messages encrypted using the cryptography plugin | ||
---|---|---|---|
Product: | [Unmaintained] kopete | Reporter: | Will Stephenson <wstephenson> |
Component: | ICQ and AIM Plugins | Assignee: | Kopete Developers <kopete-bugs-null> |
Status: | RESOLVED INTENTIONAL | ||
Severity: | normal | CC: | johann-nikolaus, rschiele |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: |
Description
Will Stephenson
2005-03-08 15:45:22 UTC
I tested this with boiko a couple of days ago, and while i don't have his public key so that i could decrypt the messages, they looked correctly formatted in the window. (I was using an icq jabber gateway with psi at the time of receipt). liboscar does nothing to mangle the message. Are we sure this is even a valid bug? Matt, how can you test whether kopete does mangle a message on receipt if you used a different application for receipt? BTW: You can just test with your own PGP key. This bug does not depend on a specific key. because the bug is about _sending_ messages from kopete, not receiving them. Ah ok, so the description is misleading. In fact the mangling does happen on receiving. if somebody could provide debug output, i _might_ take a stab at fixing this... Yep, does happen on receipt. Just sent an encrypted message from kopete to gaim and it was received as correctly formatted gpg still want/need debug output. knowing the client that is sending the message would also be useful. AFAICT, we do nothing to mangle the message on receipt. THis is independent of the client used for sending. Tested with both, licq and kopete itself. And now for the debug output of the receiving kopete: kopete (oscar - raw protocol): [void ClientStream::bs_readyRead()] recv: 992bytes kopete (oscar - raw protocol): [void CoreProtocol::addIncomingData(const QByteArray&)] Received 992 bytes. kopete (oscar - raw protocol): [virtual Transfer* SnacProtocol::parse(const QByteArray&, uint&)] family: 4 subtype: 7 flags: 0 id: 2279965831 kopete (oscar - raw protocol): [virtual bool MessageReceiverTask::take(Transfer*)] icbm cookie is [7d 54 ac 6f 39 ca 42 65 ] kopete (oscar - raw protocol): [virtual bool MessageReceiverTask::take(Transfer*)] channel is 1 kopete (oscar - raw protocol): [void UserDetails::fill(Buffer*)] Got user info for 123098950 kopete (oscar - raw protocol): [void UserDetails::fill(Buffer*)] Warning level is 0 kopete (oscar - raw protocol): [void UserDetails::fill(Buffer*)] Parsing 4 TLVs kopete (oscar - raw protocol): [void UserDetails::fill(Buffer*)] User class is 80 kopete (oscar - raw protocol): [void UserDetails::fill(Buffer*)] Extended status is 21000000 kopete (oscar - raw protocol): [void UserDetails::fill(Buffer*)] Online for 15220 kopete (oscar - raw protocol): [void UserDetails::fill(Buffer*)] Signed on at Thu Mar 17 19:57:56 2005 kopete (oscar - raw protocol): [void MessageReceiverTask::handleType1Message()] Got features tlv. length: 2 data: [01 06 ] kopete (oscar - raw protocol): [void MessageReceiverTask::handleType1Message()] Message charset: 0 message subcharset: 0 kopete (oscar - raw protocol): [void MessageReceiverTask::handleType1Message()] message is: -----BEGIN PGP MESSAGE----- Version: GnuPG v1.4.0 (GNU/Linux) hQIOA+PuQhHmd+6VEAgAv1ZRjz6J0CnKheyAza4Kz4fH5mBPXPwdcyvfrppTrAoP ZolCo8q/IwD8bVIdPWaJheqTTymf9PlI8SDoYe3+RrNvgYKFBAgjxjOQixJQhTGT VDYrHrCa1WtRacHp3x41UKni2kdnajPPEbUHXIyQlZxugmFik6lBgUxxlxwjN2Oe 5zGsbvBIm5oX9e27mZincEdIHgaHJwam4HXxqV6UrhcM7htw3dAyov/BJxW05Do/ JaOE9ybQA0Eyb5BFreAmPfBY9khhnj0LUk1gwaDVo3XriTjFqhJYA9AgwjxyuZuk knO7TinLlawD9f4aSggpOdj8P5FmfIarEWbcuatU5QgAqTUat7593kZY7WLBVZaO t4w4J9ioBSyYlVwdoZotbMs6B76JPH/q7FBiqVE5GAG1OKsNsQiqTaeS4/4ltZrD lfpAlSk6qATfjs3GKUdmSwIiYeU9LDnsZQkVE0t9u/S0XHZSPnRIlet39XJnYFES +MV3GcmZJSyvMh6EYfCrUyYYUOzPVrDE434m+xKEnIRkhoUZHluaOiW7ip4VyCPJ 1CSt70krdf41zBrYHkmru0NFVmUtrJ62iWLxwp8ECSYMD1aZ8fB9xqeuC/yHYU3i hE+pR1hNRoFRcw193HGkCZw+kmNHGIeYN6D6yMZCKc1VuR+6l/ZodsgZP0QrAIL4 79I/AeTv4YQi9qidDBO07JKTHZSgJTA5vuei7Sh7lPZgdmez0vMhODEo82Ds2H4N 6BG7X56dGEv9CivYWxOlQ/i6 =SX5Q -----END PGP MESSAGE----- kopete (oscar - raw protocol): QObject::connect: No such signal Kopete::ChatSession::typingMsg(bool) QObject::connect: (sender name: 'unnamed') QObject::connect: (receiver name: 'unnamed') kopete: statistics: new message received gpg: no valid OpenPGP data found. gpg: decrypt_message failed: eof libkopete: [void KopeteSystemTray::addBalloon()] msg text=-----BEGIN PGP MESSAGE-----Ver ... kopete (history): [void HistoryLogger::saveToDisk()] /home/robert/.kde/share/apps/kopete/logs/ICQProtocol/23497104/123098950.200503.xml saved in 26 ms libkopete: [void KopeteSystemTray::stopBlink()] stopping movie. judging from the debug output, this is not an ICQ bug. Which component do you suspect then? Note that it works for other protocols like Jabber. *** Bug 101729 has been marked as a duplicate of this bug. *** The problem also exists in groupwise... we are running the crypttext through the richtext processor, which breaks the crypttext of course. There used to be a similar bug filed against the Jabber plugin, maybe it has been reassigned to the crypto plugin. Can't find it right now but the symptoms were exactly the same. It works verry fine here, with both ICQ, MSN, and Jabber. The problem is maybe in another plugin, authoreplace, texteffect, .... can you have a look ? i have disable all plugins and the problem is still happen. But have you the correct backtrace ? doe it works with others contacts ? others protocols ? what's your verison of kopete ? It happens here too. Version 0.10 There seems to be some kind of unescape on the message that removes line breaks (and html-tags). I look through the code quickly the other day, and saw a reference (in protocols/oscarcontact.cpp) to the plainBody() method. My uneducated guess would that icq-messages are marked as RichText.. QString Message::plainBody() const { QString body=d->body; if( d->format & RichText ) { body = unescape( body ); } return body; } unescape should work perfectly. The problem is still in oscar. I've found the Bug 102880. *** This bug has been marked as a duplicate of 102880 *** With 3.5, I've found another oscar issue with crypto. PGP messages are split over two or more oscar messages. Might it be worth checking incoming messages for BEGIN PGP MESSAGE without END PGP MESSAGE in ChatSession::append, buffering incomplete crypted messages and reassembling them? won't / can't support use of cryptography over ICQ due to limitations in the protocol. |