Bug 99331 - Fix validation errors for .desktop files
Summary: Fix validation errors for .desktop files
Status: RESOLVED LATER
Alias: None
Product: konsole
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-02-14 07:35 UTC by Kurt Hindenburg
Modified: 2007-07-19 19:54 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kurt Hindenburg 2005-02-14 07:35:40 UTC
Version:            (using KDE Devel)

http://www.icefox.net/kde/tests/validatedesktop_kdebase.html


% ls *.desktop | xargs -n1 desktop-file-validate
linux.desktop: error: invalid Type "KonsoleApplication"
linux.desktop: warning: non-standard key "Schema" lacks the "X-" prefix
linux.desktop: warning: non-standard key "Font" lacks the "X-" prefix
linux.desktop: warning: non-standard key "Term" lacks the "X-" prefix
linux.desktop: warning: non-standard key "KeyTab" lacks the "X-" prefix
linux.desktop: warning: non-standard key "Cwd" lacks the "X-" prefix
mc.desktop: error: invalid Type "KonsoleApplication"
mc.desktop: warning: non-standard key "Cwd" lacks the "X-" prefix
mc.desktop: warning: non-standard key "Tips" lacks the "X-" prefix
screen.desktop: error: invalid Type "KonsoleApplication"
screen.desktop: warning: non-standard key "Cwd" lacks the "X-" prefix
shell.desktop: error: invalid Type "KonsoleApplication"
shell.desktop: warning: non-standard key "Cwd" lacks the "X-" prefix
su.desktop: error: invalid Type "KonsoleApplication"
su.desktop: warning: non-standard key "Schema" lacks the "X-" prefix
su.desktop: warning: non-standard key "Cwd" lacks the "X-" prefix
su.desktop: warning: non-standard key "Tips" lacks the "X-" prefix
sumc.desktop: error: invalid Type "KonsoleApplication"
sumc.desktop: warning: non-standard key "Schema" lacks the "X-" prefix
sumc.desktop: warning: non-standard key "Cwd" lacks the "X-" prefix
sumc.desktop: warning: non-standard key "Tips" lacks the "X-" prefix

1. Konsole checks the type==KonsoleApplication, so this can't be change to Application without code changes
2. Add a 'X-' to the non-standard keys; this requires coding changes as well.
Comment 1 Kurt Hindenburg 2005-02-14 07:44:03 UTC
Note that those above are in kdebase/konsole/other/

All of the .desktop file in kdebase/konsole/ have a lot of errors/warnings.

kcmkonsole.desktop   konsolepart.desktop     kwrited.desktop
konsole.desktop      konsole-script.desktop  terminalemulator.desktop
konsolehere.desktop  konsolesu.desktop
Comment 2 Waldo Bastian 2005-02-14 11:14:53 UTC
The .desktop file standard that the validator checks against is aimed at .desktop files that are used for the KDE menu and shared by other desktop environments. The .desktop files of konsole describe konsole sessions and are not used for the KDE menu.

If you want to change it I suggest you give them another name, e.g. .session instead of .desktop for KDE 4. I'm not sue if that's worth it though, it will cause work for our users and the benefit is doubtful.
Comment 3 Kurt Hindenburg 2005-02-14 17:28:58 UTC
O.K.  I understand that for the other/*.desktop files.  Perhaps I'll add a comment at the top of each file stating that.

The .desktop files in kdebase/konsole look to be actual .desktop files...
Comment 4 Waldo Bastian 2005-02-14 18:09:49 UTC
I only see konsolehere.desktop listed, that one is a Konqueror service menu file, not a file for the KDE menu.
Comment 5 Kurt Hindenburg 2005-02-14 18:29:50 UTC
/kdebase/konsole)> find . -iname \*desktop | grep -v other
./kwrited.desktop
./konsole/x-konsole.desktop
./kcmkonsole.desktop
./terminalemulator.desktop
./konsole-script.desktop
./konsolehere.desktop
./konsolepart.desktop
./konsolesu.desktop
./konsole.desktop


% find . -iname \*desktop | grep -v other | xargs -n1 desktop-file-validate       

Sample errors/warnings:

./konsole.desktop: warning: file contains key "DocPath", this key is currently reserved for use within KDE, and should in the future KDE releases be prefixed by "X-"
./konsole.desktop: warning: non-standard key "Test" lacks the "X-" prefix

./konsolehere.desktop: warning: file contains key "ServiceTypes", this key is currently reserved for use within KDE, and should in the future KDE releases be prefixed by "X-"
./konsolepart.desktop: warning: file specifies "Type=Service", this value for "Type" is currently reserved for use within KDE, and should in future KDE releases be prefixed by "X-"
Comment 6 Robert Knight 2007-07-19 19:54:08 UTC
There do not appear to be any errors in that list, only warnings about problems which seem to apply to many other KDE applications as well ( eg. DocPath , ServiceTypes ).  

What usually happens in this case is that they will all be fixed together with a script of some sort.