Bug 99328 - amaroK 1.2 beta4 cjk patch
Summary: amaroK 1.2 beta4 cjk patch
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-02-14 07:00 UTC by Richard Kung
Modified: 2006-06-11 12:32 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

Attachments
amarok-1.2-ranma37-20050213.patch (4.25 KB, patch)
2005-02-14 07:03 UTC, Richard Kung 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Kung 2005-02-14 07:00:26 UTC 
Version:           1.2_beta4 (using KDE KDE 3.3.2KDE 1.2)
Installed from:    Gentoo PackagesUnspecified
Compiler:          gcc 3.3.5 
OS:                Linux

amaroK 1.2 beta4 cjk patch.
Should work for any char encoding that Qt supports.

To see the effect, you must enable "Recode ID3v1 Tags" and choose a suitable "Charset" for your mp3 files.
For example, choose Big5 for Traditional Chinese.
Comment 1 Richard Kung 2005-02-14 07:03:26 UTC 
Created attachment 9612 [details]
amarok-1.2-ranma37-20050213.patch
Comment 2 Ian Monroe 2005-02-14 09:47:48 UTC 
I tried applying the patch, but this is a patch from an amaroK from a couple of weeks ago.

Would it be possible for you to merge it with the current CVS?
Comment 3 Max Howell 2005-02-14 16:05:10 UTC 
Already fixed in CVS.

You try to force all amaroK uses to store all tag types as 8bit local encoding in the second part of the patch. This obviously is something we will never do! You can do this for id3v1 tags, but no other types! CVS already does this. Please try CVS or 1.2 and check all is working for you, thanks.
Comment 4 Richard Kung 2005-02-15 17:00:09 UTC 
My bad.
Version 1.2 works with a workaround.
I have to choose charset "eucJP".
But my test file is encoded with "Big5".
Maybe there is shift of AmarokConfig::recodeEncoding() ?
Comment 5 Max Howell 2005-02-15 21:45:05 UTC 
Fixed in CVS
Comment 6 Richard Kung 2005-02-16 14:29:35 UTC 
CVS works for me.
Thanks for doing this for we non-latin users :)