Bug 98589 - mark thread as Todo doesn't mark all messages in the thread
Summary: mark thread as Todo doesn't mark all messages in the thread
Status: RESOLVED FIXED
Alias: None
Product: kmail
Classification: Applications
Component: message list (show other bugs)
Version: SVN (3.5 branch)
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2005-02-05 02:34 UTC by Allen Winter
Modified: 2008-08-31 14:26 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Screenshot showing a thread with some messages missing the Todo icon (9.01 KB, image/png)
2005-02-05 02:35 UTC, Allen Winter
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Allen Winter 2005-02-05 02:34:05 UTC
Version:            (using KDE Devel)
Installed from:    Compiled sources

When I select "Mark thread as Todo" from the RMB menu, some messages
in the thread may not be marked -- or at least they don't have the todo icon.
The messages which don't get marked seem to be the ones which are replies.

I will send a screenshot of an example where I have a thread which I have
marked as Todo and as Important.  You will see that each message in the 
thread has the Important icon, but two are missing the Todo icon.
The two with the missing Todo icon have a Reply icon.
Comment 1 Allen Winter 2005-02-05 02:35:47 UTC
Created attachment 9431 [details]
Screenshot showing a thread with some messages missing the Todo icon
Comment 2 Till Adam 2005-02-05 12:17:08 UTC
I assume they do have the right status, just not the icon? Probably because 
off the icon merging going on because they are replies? Can you check with 
the quick search whether they have the right status?

Comment 3 Allen Winter 2005-02-05 13:46:56 UTC
Hi Till.

Yes, they have the right status according to the quick search.
It is just that the Todo icon is missing.

PS:  In KOrganizer we changed all occurrences of "Todo" with "To-do".
Something to consider for KMail.

PS2:  For consistency, the menu entry "Mark Thread as &todo" should be "Mark Thread as &Todo"
or possibly "Mark Thread as &To-do".

-Allen

Comment 4 Till Adam 2005-02-05 14:01:27 UTC
On Saturday 05 February 2005 13:46, Allen Winter wrote:

> Yes, they have the right status according to the quick search.
> It is just that the Todo icon is missing.

Ok, so that's a regression from the icon merging.

> PS:  In KOrganizer we changed all occurrences of "Todo" with "To-do".
> Something to consider for KMail.

Yeah, although I still prefer "Task", for KOrganizer. For KMail I would prefer 
To-do, though. 

> PS2:  For consistency, the menu entry "Mark Thread as &todo" should be
> "Mark Thread as &Todo" or possibly "Mark Thread as &To-do".

The string freeze just started. I'm not sure that such a change would not 
break it?

Till

Comment 5 Allen Winter 2005-02-05 14:42:01 UTC
On Saturday 05 February 2005 08:01 am, Till Adam wrote:
> ------- Additional Comments From adam kde org  2005-02-05 14:01 -------
> On Saturday 05 February 2005 13:46, Allen Winter wrote:
> 
> > Yes, they have the right status according to the quick search.
> > It is just that the Todo icon is missing.
> 
> Ok, so that's a regression from the icon merging.
> 
> > PS:  In KOrganizer we changed all occurrences of "Todo" with "To-do".
> > Something to consider for KMail.
> 
> Yeah, although I still prefer "Task", for KOrganizer. For KMail I would prefer 
> To-do, though. 
> 
> > PS2:  For consistency, the menu entry "Mark Thread as &todo" should be
> > "Mark Thread as &Todo" or possibly "Mark Thread as &To-do".
> 
> The string freeze just started. I'm not sure that such a change would not 
> break it?
> 
Probably not worth changing and getting yelled at :)

Comment 6 Allen Winter 2005-02-26 02:20:38 UTC
CVS commit by winterz: 

String changes for To-do marked messages.
I discussed this with Till and he agreed with me to change these strings
to make things consistent across PIM.
CCBUGS: 98589


  M +4 -4      kmmainwidget.cpp   1.321


--- kdepim/kmail/kmmainwidget.cpp  #1.320:1.321
@@ -2450,8 +2450,8 @@ void KMMainWidget::setupActions()
   mStatusMenu->insert( mToggleFlagAction );
 
-  mToggleTodoAction = new KToggleAction(i18n("Mark Message as &Todo"), "kontact_todo",
+  mToggleTodoAction = new KToggleAction(i18n("Mark Message as &To-do"), "kontact_todo",
                                  0, this, SLOT(slotSetMsgStatusTodo()),
                                  actionCollection(), "status_todo");
-  mToggleTodoAction->setCheckedState( i18n("Mark Message as Not &Todo") );
+  mToggleTodoAction->setCheckedState( i18n("Mark Message as Not &To-do") );
   mStatusMenu->insert( mToggleTodoAction );
 
@@ -2524,8 +2524,8 @@ void KMMainWidget::setupActions()
   mThreadStatusMenu->insert( mToggleThreadFlagAction );
 
-  mToggleThreadTodoAction = new KToggleAction(i18n("Mark Thread as &todo"), "kontact_todo",
+  mToggleThreadTodoAction = new KToggleAction(i18n("Mark Thread as &To-do"), "kontact_todo",
                                        0, this, SLOT(slotSetThreadStatusTodo()),
                                        actionCollection(), "thread_todo");
-  mToggleThreadTodoAction->setCheckedState( i18n("Mark Thread as Not &Todo") );
+  mToggleThreadTodoAction->setCheckedState( i18n("Mark Thread as Not &To-do") );
   mThreadStatusMenu->insert( mToggleThreadTodoAction );
 


Comment 7 Jaime Torres 2008-08-31 12:17:45 UTC
I've checked it in 1.10.0 (kde 4.1.60 svn trunk 838252) and it marks all the mails in the thread.