Bug 98564 - new setting: tied zoom through all windows
Summary: new setting: tied zoom through all windows
Status: RESOLVED FIXED
Alias: None
Product: kst
Classification: Applications
Component: general (show other bugs)
Version: 1.x
Platform: unspecified Solaris
: HI wishlist
Target Milestone: ---
Assignee: kst
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-02-04 18:02 UTC by Nicolas Brisset
Modified: 2006-03-06 22:01 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Proposed patch (25.35 KB, patch)
2006-02-25 01:52 UTC, Andrew Walker
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Brisset 2005-02-04 18:02:46 UTC
Version:           1.1.0_dr1 (using KDE 3.3.0, compiled sources)
Compiler:          gcc version 3.3.2
OS:                SunOS (sun4u) release 5.8

Tied zoom is a very neat feature. However, in some use cases you might be using more than one window to look at a lot of data. If you zoom in a given area, even with tied zoom only plots in the current window are zoomed. It would be nice to add an option (probably in the general kst settings) to tell kst whether "tied" should be understood on a per-window basis or applied to all windows. The current behavior is probably a good default (think PSDs etc) but global tied zoom would be very helpful in some cases.
Comment 1 George Staikos 2005-02-08 02:06:16 UTC
Barth had said he wanted it to only work per-window.  Barth?
Comment 2 Nicolas Brisset 2005-02-14 11:54:03 UTC
I think there are pretty different use cases for kst out there, and that's why I believe a kst setting would be appropriate. I know some people who would definitely want it to work globally. 
Now, I have no idea how difficult it would be to implement it. But if it's easy, I don't see any reason to not do it, as long as it remains a _configurable option_.
Comment 3 Andrew Walker 2005-04-13 03:06:29 UTC
CVS commit by arwalker: 

Added ability to define a cursor position within a plot by hitting the 'C' button (Hit SHIFT+'C" to remove the cursor). Once a cursor is set the status bar will show the offset from the cursor position to the current mouse position. This functionality also works in data mode.

Do we want to add an item to the context menu for this?

CCMAIL: 98564@bugs.kde.org


  M +249 -90   kst2dplot.cpp   1.393
  M +12 -2     kst2dplot.h   1.153
Comment 4 Andrew Walker 2005-04-13 03:08:50 UTC
Please ingore previous comment. Attached to wrong bug report.
Comment 5 Matthew Truch 2005-11-16 23:08:11 UTC
Enzo says: "This feature would be very useful."

I agree.
Comment 6 Andrew Walker 2006-01-26 19:43:14 UTC
Should be fixed for 1.2.1 release
Comment 7 Andrew Walker 2006-02-24 20:50:33 UTC
I would propose adding a "Apply tied-zoom globally" checkbox to the General tab of the Kst Settings dialog. If checked the tied-zoom feature would work across all windows, otherwise it would continue to work as it does now.
Comment 8 Andrew Walker 2006-02-25 01:52:25 UTC
Created attachment 14859 [details]
Proposed patch

Makes global/window tied zoom configurable from Kst Settings dialog.

Also fixes several bugs where previously different zoom modes worked either
only on themselves, only across the window, or across all windows (though for
the last the updates for plots in other windows were not occurring).
Comment 9 Netterfield 2006-02-25 21:15:37 UTC
Seems to work fine, but for some reason, minor grid lines are now default from 
the wizard...  This is either from this patch, or a recent one from George.

Also, I see that this fixes the log range 'bug' which is good.

Go ahead and commit, but lets find the minor y grid bug.

cbn

On February 24, 2006 04:52 pm, Andrew Walker wrote:
[bugs.kde.org quoted mail]
Comment 10 George Staikos 2006-02-25 21:54:43 UTC
On Sunday 26 February 2006 18:32, Barth Netterfield wrote:
> Seems to work fine, but for some reason, minor grid lines are now default
> from the wizard...  This is either from this patch, or a recent one from
> George.
>
> Also, I see that this fixes the log range 'bug' which is good.
>
> Go ahead and commit, but lets find the minor y grid bug.


  Conceptually it's fine with me but why does it have to touch KstApp and 
KstTopLevelView?  We have everything we need in Kst2DPlot.  It seems 
unnecessarily intrusive.   And beyond that, KstApp and KstTopLevelView really 
shouldn't know about Kst2DPlot.  I've been working to remove references to 
it.
Comment 11 Andrew Walker 2006-02-27 23:35:07 UTC
SVN commit 514309 by arwalker:

BUG:98564 Better handle tied zoom locally and globally

 M  +4 -0      libkst/kstsettings.cpp  
 M  +1 -0      libkst/kstsettings.h  
 M  +57 -0     libkstapp/kst.cpp  
 M  +4 -1      libkstapp/kst.h  
 M  +116 -108  libkstapp/kst2dplot.cpp  
 M  +4 -37     libkstapp/kst2dplot.h  
 M  +23 -0     libkstapp/kstsettingsdlg.ui  
 M  +4 -1      libkstapp/kstsettingsdlg.ui.h  
 M  +44 -0     libkstapp/ksttoplevelview.cpp  
 M  +5 -1      libkstapp/ksttoplevelview.h  
Comment 12 Andrew Walker 2006-03-06 22:01:07 UTC
SVN commit 516363 by arwalker:

CCBUG:98564 Replaced void* with const QString&

 M  +9 -9      kst.cpp  
 M  +3 -3      kst.h  
 M  +24 -24    kst2dplot.cpp  
 M  +6 -6      ksttoplevelview.cpp  
 M  +3 -3      ksttoplevelview.h