Bug 97961 - wish: Lyrics offline Database (like cover browser)
Summary: wish: Lyrics offline Database (like cover browser)
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: general (show other bugs)
Version: 1.2-beta2
Platform: Gentoo Packages Linux
: NOR wishlist
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
: 100922 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-01-26 23:47 UTC by th_spam
Modified: 2006-06-11 12:32 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Patch (against cvs on 27 01 2005) (2.37 KB, patch)
2005-01-27 18:42 UTC, Alexandre Oliveira
Details

Note You need to log in before you can comment on or make changes to this bug.
Description th_spam 2005-01-26 23:47:03 UTC
Version:           1.2-beta2 (using KDE KDE 3.3.2)
Installed from:    Gentoo Packages
OS:                Linux

Hi,

First: I love amarok, keep on working, it's a really great project!

My feature request: Resolving Lyrics always takes some time, it's a bit ... let me say "annoying" - if you just wanna switch to your collection browser.

A local cache for lyrics like the cover browser would be great. Maybe you'll add a button that says "save this lyrics" to the lyrics window? Would be great!

Th
Comment 1 Alexandre Oliveira 2005-01-27 18:42:38 UTC
Created attachment 9316 [details]
Patch (against cvs on 27 01 2005)

With this patch, it will order the albums by their year tag.
Comment 2 Sami Nieminen 2005-01-27 18:48:56 UTC
Comment on attachment 9316 [details]
Patch (against cvs on 27 01 2005)

Attached to wrong bug report
Comment 3 Mark Kretschmann 2005-01-28 09:51:20 UTC
We don't want to save the lyrics locally, for legal reasons. We're not really sure about the legal implications, but don't want to take any risks. (lyrics are copyrighted material).
Comment 4 th_spam 2005-01-28 15:27:30 UTC
So CD covers aren't??? That's new to me :)
Comment 5 Christian Muehlhaeuser 2005-01-28 18:28:26 UTC
yep, they are. but there's an amazon license to use amazon's covers, which we accepted. if you find something similar for lyrics, we'd be happy.

regards,
muesli
Comment 6 Fred Schättgen 2005-01-30 01:24:10 UTC
Too bad. This means that searching the lyrics will also be impossible :-[
I was about to add a feature request for that.

But is there a legal difference between downloading copyrighted material only to use it for a limited time (caching) and storing it permanently?
If there is one, then why don't we receive our music on demand and in realtime from servers in a country where copyright doesn't matter? Does storing the data really make the difference?

Comment 7 Mark Kretschmann 2005-01-30 01:47:05 UTC
On Sunday 30 January 2005 01:24, Fred SchÀttgen wrote:
> But is there a legal difference between downloading copyrighted material
> only to use it for a limited time (caching) and storing it permanently? If
> there is one, then why don't we receive our music on demand and in realtime
> from servers in a country where copyright doesn't matter? Does storing the
> data really make the difference?

I don't know, really. IANAL.

Comment 8 Stefan Siegel 2005-01-30 09:27:56 UTC
AFAIK in Germany it is perfectly legal to store anything you download legally from the Internet for private use, provided you don't redistribute it. This is §53 UrhG and usually called "Privatkopie" ("private copy").

It is also legal to download cover images from the Amazon website and store them permanently with your audio files. But because we use the Amazon API to download covers we need a license key for it, and to get a key we must accept to design our software a way Amazon wants us to do (linking the cover to amazon.com and deleting it after 3 months).

It would also be legal for amaroK users to look at each image in the cover image cache directory and copy it into the corresponding album directory for permanently storing it.
Comment 9 Alexandre Oliveira 2005-03-06 17:46:20 UTC
*** Bug 100922 has been marked as a duplicate of this bug. ***
Comment 10 Christian Loose 2005-03-07 13:13:40 UTC
For me implementing Bug 85961 (support for Lyrics in id3) would be enough "offline availability".
Comment 11 Fred Schättgen 2005-04-06 13:31:52 UTC
If I understand this correctly the only concern are the potential legal implications.
Wouldn't it be better not to hardcode one lyrics download service into amarok and have the user provide a lyrics download URL instead? In that case amarok isn't "recommending" a special service and it would be the responsibility of the user to choose a service which is legal for him. At the moment it's absolutely not transparent to the user where the lyrics are coming from.
Anyway, I don't see how storing the lyrics could worsen the current situation. 
And it would be *so* cool to have a lyrics manager with a search line at the top :)
Comment 12 Mark Kretschmann 2005-04-06 13:59:54 UTC
On Wednesday 06 April 2005 13:31, Fred SchÀttgen wrote:
> legal implications. Wouldn't it be better not to hardcode one lyrics
> download service into amarok and have the user provide a lyrics download
> URL instead?


You forget that amaroK must also parse the lyrics site. It's not like the same 
code would work for random sites.
Comment 13 Leo Spalteholz 2005-04-20 08:03:53 UTC
Is it possible to create a plugin that saves the lyrics and provides a lyric browser/search?  This would be an alternative for someone that is willing to accept the legal risk while keeping it out of amarok proper.  Then people in countries where this is legal can use the plugin.
Comment 14 Alesha 2005-04-23 12:38:16 UTC
I NEED LOCAL LYRICS SYSTEM :).In my country(Russia) nobody look is this lyrics legal or not,we have other problems.You must create such lyrics system,but warrn user,that this is not very legal.
P.S.Dreaming of local lyrics.....
P.S.S.Please,make such system :) make millions of users happy ;)
Comment 15 Mauricio Bahamonde 2005-05-08 02:46:38 UTC
<i>Lyrics are copyrighted material</i>

Of whom? The person that writes and uploads the lyrics of the song, or the original author of the song's lyric? Or the site holding the lyrics?
Comment 16 Ian Monroe 2005-05-08 06:46:37 UTC
In the US the copyright holder of the song holds the rights to the lyrics. This is the kind of thing that varies between countries though.

We just need a way for the user to manually store the lyrics.
Comment 17 Kristjan Ugrin 2005-05-08 11:28:19 UTC
Is possible to create an plugin for amarok, which will parse site, download and store lyrics, show them in lyrics tab, "unofficially"? So everyone who would use it, it would be theirself responsability. I'm on dial-up, but I like reading lyrics, but I cannot estabilish a connection every time I want, it is expensive!!!
Comment 18 Anthony Ivanoff 2005-05-22 09:22:20 UTC
Hello guys,

For those of you who REALLY need to store lyrics locally, I wrote a simple dirty hack.
The patch is for amaroK v1.2.4 and is available here: http://www.linux.org.ru/jump-message.jsp?msgid=920234

It stores all the lyrics in /hda9/Texts/ (yes, that's my dir, replace every occurence of it with your own directory name). It also adds a link "Refresh lyrics" to the top of the page in case you decide to update the lyrics or downloaded the wrong lyrics.

P.S. I've been using amaroK for less than 1 day and I already love it! Keep up good work!
Comment 19 Kristjan Ugrin 2005-05-28 10:59:47 UTC
Can someone help me apply this patch? I don't know how.
Comment 20 Mark Kretschmann 2005-07-28 09:18:33 UTC
SVN commit 439448 by markey:

Update ChangeLog for implemented wishes:

* New DCOP call "player: lyrics" (BR 100306) and Lyrics Caching. (BR 97961)

BUG: 100306
BUG: 97961



 M  +1 -1      ChangeLog  


--- trunk/extragear/multimedia/amarok/ChangeLog #439447:439448
@@ -7,7 +7,7 @@
   FEATURES:
     * New OSD tokens: %directory and %type (shows whether it's a stream, or
       otherwise the extension).
-    * New DCOP call "lyrics" and Lyrics Caching!
+    * New DCOP call "player: lyrics" (BR 100306) and Lyrics Caching. (BR 97961)
     * New DCOP call "player: transferDeviceFiles". Transfers queued files to
       the Media Device.
     * New DCOP call "player: queueForTransfer". Queues files for transfer to
Comment 21 Thiago Macieira 2005-11-04 19:12:21 UTC
*** Bug 100922 has been marked as a duplicate of this bug. ***