Bug 97954 - Bad quietban (mode +q) notice
Summary: Bad quietban (mode +q) notice
Status: RESOLVED FIXED
Alias: None
Product: konversation
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Slackware Linux
: NOR normal
Target Milestone: ---
Assignee: Konversation Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-01-26 21:26 UTC by Marco Gulino
Modified: 2010-07-01 16:01 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Marco Gulino 2005-01-26 21:26:07 UTC 
Version:            (using KDE KDE 3.3.91)
Installed from:    Slackware Packages
OS:                Linux

When setting mode +q (quietban) to a user, you can see only
 "mode +q to #channel", but you can't see to what user it's applied.
Comment 1 Ismail Donmez 2005-03-27 11:49:30 UTC 
CVS commit by cartman: 

Handle quiet bans better
BUG:97954


  M +6 -4      channel.cpp   1.304


--- kdeextragear-2/konversation/konversation/channel.cpp  #1.303:1.304
@@ -1413,11 +1413,13 @@ void Channel::updateMode(QString sourceN
       if(plus)
       {
-        if(fromMe) message=i18n("You set the channel mode to 'quiet'.");
-        else message=i18n("%1 sets the channel mode to 'quiet'.").arg(sourceNick);
+        QString user = parameter.isEmpty() ? "" : "on "+parameter;
+        if(fromMe) message=i18n("You set the channel mode to 'quiet' %1.").arg(user);
+        else message=i18n("%1 sets the channel mode to 'quiet' %2.").arg(sourceNick).arg(user);
       }
       else
       {
-        if(fromMe) message=i18n("You remove the 'quiet' channel mode.");
-        else message=i18n("%1 removes the 'quiet' channel mode.").arg(sourceNick);
+        QString user = parameter.isEmpty() ? "" : "on "+parameter;
+        if(fromMe) message=i18n("You remove the 'quiet' channel mode %1.").arg(user);
+        else message=i18n("%1 removes the 'quiet' channel mode %1.").arg(sourceNick).arg(user);
       }
Comment 2 Ismail Donmez 2010-07-01 16:01:05 UTC 
commit 8360c657dc628cf7d2b47927bb955d0989bb2211
Author: İsmail Dönmez <ismail@kde.org>
Date:   Sun Mar 27 09:49:21 2005 +0000

    Handle quiet bans better
    BUG:97954
    
    svn path=/trunk/kdeextragear-2/konversation/; revision=400926

diff --git a/konversation/channel.cpp b/konversation/channel.cpp
index 48f0161..8a93bef 100644
--- a/konversation/channel.cpp
+++ b/konversation/channel.cpp
@@ -1412,13 +1412,15 @@ void Channel::updateMode(QString sourceNick, char mode, bool plus, const QString
     case 'q':
       if(plus)
       {
-        if(fromMe) message=i18n("You set the channel mode to 'quiet'.");
-        else message=i18n("%1 sets the channel mode to 'quiet'.").arg(sourceNick);
+	QString user = parameter.isEmpty() ? "" : "on "+parameter;
+        if(fromMe) message=i18n("You set the channel mode to 'quiet' %1.").arg(user);
+        else message=i18n("%1 sets the channel mode to 'quiet' %2.").arg(sourceNick).arg(user);
       }
       else
       {
-        if(fromMe) message=i18n("You remove the 'quiet' channel mode.");
-        else message=i18n("%1 removes the 'quiet' channel mode.").arg(sourceNick);
+	QString user = parameter.isEmpty() ? "" : "on "+parameter;
+        if(fromMe) message=i18n("You remove the 'quiet' channel mode %1.").arg(user);
+        else message=i18n("%1 removes the 'quiet' channel mode %1.").arg(sourceNick).arg(user);
       }
 
     break;