Bug 97693 - kdeaddons-3.3.2: "make check" fails in konq-plugins/fsview
Summary: kdeaddons-3.3.2: "make check" fails in konq-plugins/fsview
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: fsview (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Josef Weidendorfer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-01-23 02:12 UTC by Sascha Silbe
Modified: 2005-01-25 10:10 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sascha Silbe 2005-01-23 02:12:09 UTC
Version:            (using KDE KDE 3.3.2)
Installed from:    Gentoo Packages
Compiler:          gcc-3.3.5 x86 
OS:                Linux

When trying to build kdeaddons-3.3.2 on Gentoo with FEATURES=maketest - which automatically invokes "make check" - I get these errors:

Making check in fsview
make[2]: Entering directory `/var/tmp/portage/kdeaddons-3.3.2/work/kdeaddons-3.3.2/konq-plugins/fsview'
make  scantest
make[3]: Entering directory `/var/tmp/portage/kdeaddons-3.3.2/work/kdeaddons-3.3.2/konq-plugins/fsview'
i686-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I. -I../.. -I/usr/kde/3.3/include -I/usr/qt/3/include -I/usr/X11R6/include   -DQT_THREAD_SUPPORT  -D_REENTRANT  -Wnon-virtual-dtor -Wno-long-long -Wundef -ansi -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -Wcast-align -Wconversion -Wchar-subscripts -Wall -W -Wpointer-arith -Wwrite-strings -DNDEBUG -DNO_DEBUG -O2 -O3 -march=athlon-xp -pipe -fomit-frame-pointer -Wformat-security -Wmissing-format-attribute -fno-exceptions -fno-check-new -fno-common -DQT_CLEAN_NAMESPACE -DQT_NO_ASCII_CAST -DQT_NO_STL -DQT_NO_COMPAT -DQT_NO_TRANSLATION  -c -o scantest.o scantest.cpp
In file included from scantest.cpp:24:
scan.h:29: error: syntax error before `;' token
In file included from scantest.cpp:24:
scan.h:138: error: type specifier omitted for parameter `FSViewSize'
scan.h:138: error: parse error before `)' token
scan.h:142: error: parse error before `)' token
scan.h:145: error: semicolon missing after declaration of `ScanFile'
scan.h: In member function `const QString& ScanFile::name()':
scan.h:141: error: `_name' undeclared (first use this function)
scan.h:141: error: (Each undeclared identifier is reported only once for each
   function it appears in.)
scan.h: At global scope:
scan.h:145: error: ISO C++ forbids defining types within return type
scan.h:145: error: two or more data types in declaration of `setListener'
scan.h:145: error: semicolon missing after declaration of `class ScanFile'
scan.h: In function `int setListener(ScanListener*)':
scan.h:145: error: `_listener' undeclared (first use this function)
scan.h:145: warning: no return statement in function returning non-void
scan.h: At global scope:
scan.h:148: error: parse error before `private'
scan.h:150: error: 'FSViewSize' is used as a type, but is not defined as a
   type.
scan.h:151: error: `ScanListener*_listener' used prior to declaration
scan.h:152: error: parse error before `}' token
scan.h:196: error: parse error before `)' token
scan.h:197: error: semicolon missing after declaration of `ScanDir'
scan.h: In member function `int ScanDir::data()':
scan.h:190: error: `_data' undeclared (first use this function)
scan.h: In member function `ScanFileVector& ScanDir::files()':
scan.h:193: error: `_files' undeclared (first use this function)
scan.h: In member function `ScanDirVector& ScanDir::dirs()':
scan.h:194: error: `_dirs' undeclared (first use this function)
scan.h: At global scope:
scan.h:197: error: ISO C++ forbids defining types within return type
scan.h:197: error: extraneous `int' ignored
scan.h:197: error: long, short, signed or unsigned invalid for `fileCount'
scan.h:197: error: semicolon missing after declaration of `class ScanDir'
scan.h: In function `int fileCount()':
scan.h:197: error: `update' undeclared (first use this function)
scan.h:197: error: `_fileCount' undeclared (first use this function)
scan.h: In function `unsigned int dirCount()':
scan.h:198: error: `_dirCount' undeclared (first use this function)
scan.h: In function `ScanDir* parent()':
scan.h:199: error: `_parent' undeclared (first use this function)
scan.h: In function `bool scanStarted()':
scan.h:200: error: `_dirsFinished' undeclared (first use this function)
scan.h: At global scope:
scan.h:205: error: new declaration `void setListener(ScanListener*)'
scan.h:145: error: ambiguates old declaration `int setListener(ScanListener*)'
scan.h: In function `ScanListener* listener()':
scan.h:206: error: redefinition of `ScanListener* listener()'
scan.h:146: error: `ScanListener* listener()' previously defined here
scan.h:206: error: redefinition of `ScanListener* listener()'
scan.h:146: error: `ScanListener* listener()' previously defined here
scan.h: In function `ScanManager* manager()':
scan.h:207: error: `_manager' undeclared (first use this function)
scan.h: At global scope:
scan.h:212: error: parse error before `private'
scan.h:221: error: `ScanFileVector _files' used prior to declaration
scan.h:222: error: `ScanDirVector _dirs' used prior to declaration
scan.h:224: error: `QString _name' used prior to declaration
scan.h:226: error: parse error before `,' token
scan.h:227: error: `unsigned int _fileCount' used prior to declaration
scan.h:227: error: `unsigned int _dirCount' used prior to declaration
scan.h:228: error: `int _dirsFinished' used prior to declaration
scan.h:228: error: `int _data' used prior to declaration
scan.h:229: error: `ScanDir*_parent' used prior to declaration
scan.h:230: error: redefinition of `ScanListener*_listener'
scan.h:151: error: `ScanListener*_listener' previously declared here
scan.h:231: error: `ScanManager*_manager' used prior to declaration
scan.h:232: error: parse error before `}' token
scantest.cpp: In member function `virtual void
   MyListener::sizeChanged(ScanDir*)':
scantest.cpp:38: error: `dirCount' undeclared (first use this function)
scantest.cpp:38: error: `fileCount' undeclared (first use this function)
scantest.cpp:38: error: `size' undeclared (first use this function)
{standard input}: Assembler messages:
{standard input}:66: Error: symbol `_listener' is already defined
make[3]: *** [scantest.o] Error 1
make[3]: Leaving directory `/var/tmp/portage/kdeaddons-3.3.2/work/kdeaddons-3.3.2/konq-plugins/fsview'
make[2]: *** [check-am] Error 2
make[2]: Leaving directory `/var/tmp/portage/kdeaddons-3.3.2/work/kdeaddons-3.3.2/konq-plugins/fsview'
make[1]: *** [check-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/kdeaddons-3.3.2/work/kdeaddons-3.3.2/konq-plugins'
make: *** [check-recursive] Error 1

!!! ERROR: kde-base/kdeaddons-3.3.2 failed.
!!! Function src_test, Line 566, Exitcode 0
!!! Make check failed. See above for details.
!!! If you need support, post the topmost build error, NOT this status message.


See also Gentoo bug #79070 (http://bugs.gentoo.org/show_bug.cgi?id=79070).
Comment 1 Josef Weidendorfer 2005-01-23 22:30:56 UTC
Fixed. Perhaps better would be to comment out the check target lines in Makefile.am.
Comment 2 Sascha Silbe 2005-01-24 06:50:19 UTC
Could you please attach the patch so Gentoo can include it for the 3.3.2 ebuild?  
Comment 3 Josef Weidendorfer 2005-01-25 10:10:07 UTC
It's only a 1-liner. The changes for scan.cpp fix a warning only:

--- kdeaddons/konq-plugins/fsview/scan.h        2004/08/26 14:49:21     1.3
+++ kdeaddons/konq-plugins/fsview/scan.h        2005/01/23 21:16:30     1.4
@@ -26,6 +26,7 @@
 #define USE_64BIT_SIZES 1
 
 #if USE_64BIT_SIZES
+#include <qglobal.h>
 typedef Q_INT64 FSViewSize;
 #else
 typedef QFile::Offset FSViewSize;
--- kdeaddons/konq-plugins/fsview/scantest.cpp  2004/03/01 22:13:14     1.2
+++ kdeaddons/konq-plugins/fsview/scantest.cpp  2005/01/23 21:16:30     1.3
@@ -33,9 +33,14 @@
 
   void sizeChanged(ScanDir* d)
   {
-    printf("Change in %s (Dirs %d, Files %d, Size %u)\n",
+    printf("Change in %s: Dirs %d, Files %d",
           d->name().latin1(), 
-          d->dirCount(), d->fileCount(), d->size());
+          d->dirCount(), d->fileCount());
+#if USE_64BIT_SIZES
+    printf("Size %llu\n", d->size());
+#else
+    printf("Size %u\n", d->size());
+#endif
   }
 
   void scanFinished(ScanDir* d)