Bug 96903 - birthday reminder displays birthdays too late
Summary: birthday reminder displays birthdays too late
Status: RESOLVED FIXED
Alias: None
Product: kresources
Classification: Miscellaneous
Component: birthdays (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Reinhold Kainhofer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-01-13 12:10 UTC by markus
Modified: 2005-01-14 15:01 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description markus 2005-01-13 12:10:38 UTC
Version:           3.3.1 (using KDE 3.3.1,  (3.1))
Compiler:          gcc version 3.3.5 (Debian 1:3.3.5-3)
OS:                Linux (i686) release 2.6.9

today (13.01.2005) I got a reminder that a friend of mine has his birthday on 19.11. 

this is a little awkward. I got this kind of wrong-dated reminders already several times and I have the impression that the time lag is roughly the same even though I have not tested it (I never bothered to write down the date in order to compare it next time)...

But this is something that has to be mentioned (and fixed) at last...!

Best wishes for the new year!

Markus
Comment 1 markus 2005-01-14 12:39:15 UTC
Today (14.01.2005) I got another reminder for a birthday on 20.11. It is not clear that the time lag is a fixed delay.
Comment 2 Reinhold Kainhofer 2005-01-14 12:51:45 UTC
Hi Markus,
So you have the birthday resource enabled in korganizer. Can you please go the settings dialog of the birthday resource and check which alarm settings are set there? 

Cheers,
Reinhold
Comment 3 markus 2005-01-14 13:18:52 UTC
Reinhold,

I have a default of 1048592 days in advance. Maybe this is the reason... But then I wonder why this default is there? I have now set it to 3 days and I will report on this issue when the next birthday occurs. 

Thanks!
Comment 4 Reinhold Kainhofer 2005-01-14 14:07:31 UTC
Okay, so now we tracked down the reason. I'm experiencing the same wrong alarm default if I add a new birthday resource, so this is completely reproducable...

Cheers,
Reinhold
Comment 5 Reinhold Kainhofer 2005-01-14 14:15:23 UTC
CVS commit by kainhofe: 

Properly initialize the values for the birthday resource (if config==0, like it is the case when you create a new resource, the values were never initialized...)
BUG: 96903


  M +2 -5      resourcekabc.cpp   1.29


--- kdepim/libkcal/resourcekabc.cpp  #1.28:1.29
@@ -65,5 +65,5 @@ extern "C"
 
 ResourceKABC::ResourceKABC( const KConfig* config )
-  : ResourceCalendar( config )
+  : ResourceCalendar( config ), mAlarmDays( 1 ), mAlarm( false )
 {
   if ( config ) {
@@ -75,9 +75,6 @@ ResourceKABC::ResourceKABC( const KConfi
 
 ResourceKABC::ResourceKABC( )
-  : ResourceCalendar( 0 )
+  : ResourceCalendar( 0 ), mAlarmDays( 1 ), mAlarm( false )
 {
-  mAlarmDays = 1;
-  mAlarm = false;
-
   init();
 }


Comment 6 markus 2005-01-14 15:01:02 UTC
Reinhold,

Well, I mistyped in my message above - as I now re-read it. Off course it was clear that the time lag was a constant. Delete "not", set "now" ;-)

Thanks for your efforts! A fix time of 26 hours is natural for open source... But tell this to M$... :-)) 

Best wishes!
Markus