Bug 96872 - [patch] Add playlist actions next to the "albums by ...· in ContextView
Summary: [patch] Add playlist actions next to the "albums by ...· in ContextView
Status: RESOLVED INTENTIONAL
Alias: None
Product: amarok
Classification: Applications
Component: Context View (show other bugs)
Version: 2.0-SVN
Platform: Debian testing Linux
: VLO wishlist
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-01-12 22:28 UTC by Matías Costa
Modified: 2009-06-19 14:38 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Add playlist actions to album list in context browser (7.46 KB, patch)
2005-01-12 22:30 UTC, Matías Costa
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matías Costa 2005-01-12 22:28:38 UTC
Version:           1.2-CVS (using KDE KDE 3.3.2)
Installed from:    Debian testing/unstable Packages
Compiler:          gcc 3.3.5 
OS:                Linux

This patch adds the same actions you get with the contextual menu (aka RMB menu) next to album in the context browser. Sure you understand it with this snapshot:

http://webs.ono.com/uucp/amarok-new.png

So you can append, queue etc a album to the playlist in a easy way. The idea is not mine. From slotContextMenu():

//TODO it would be handy and more usable to have this menu under the cover one too 

PD: This patch tries to be lees intrusive as posible. So I add album-append, album-make and album-queue (with "x @@@ y") to the url openUrlRequest(). But I believe it is more elegant album:/add?artist=xxxx style links. If you are OK with this notify me and I'll do the work.
Comment 1 Matías Costa 2005-01-12 22:30:06 UTC
Created attachment 9062 [details]
Add playlist actions to album list in context browser
Comment 2 Max Howell 2005-01-14 22:42:38 UTC
I personally think this clutters the context browser, and the icons, even though they are the ones we use in the menus, are completely impossible to identify purpose from.

What do others think?

Thanks for the work though.
Comment 3 Reigo Reinmets 2005-03-08 20:27:46 UTC
I basicaly like the idea of those buttons. But they are hard to identify indeed, then again, why else do we have tooltips? And it could resolve our other bug about mis-clicking on the name of the album to maximise it. See bug 98797
Comment 4 Ian Monroe 2005-03-10 07:01:17 UTC
I indeed do not know what those buttons do.
Comment 5 Matías Costa 2005-03-10 11:51:11 UTC
I have been quiet because I respect Max Howell opinion. May be this clutters the interface, and if devs thinks so, I'm right if the patch does not get commited. 

But... to get the same functionality you must RMB click on the album name. This is not obvious for the average user. And as Reigo Reinmets has stated, should resolve Bug#98797 issue (if you think this is a real issue, I think so)

But I believe Ian Monroe opinion is not right. The same apply to the rand and repeat buttons in the status bar, and users love them. Please note the patch provide tooltip info, a well know method to get help for almost all users.
Comment 6 Max Howell 2005-03-10 23:14:27 UTC
We do need to do something about this. I say commit for 1.3 and we'll sort it out. There are definately too many icons at the moment, and the icons are inappropriate. But hopefully someone will make better icons for us and we can sort out which ones to keep.

I'm for one icon that expands/contracts the album info. The rest can be got with right-click and standard single click on the rest of the album section.
Comment 7 Reigo Reinmets 2005-04-22 08:57:50 UTC
Well? 1.3 devel is going on already for a long time, i have'nt seen this commited yet!
Comment 8 Danny Angelo Carminati Grein 2007-02-16 16:21:53 UTC
*** This bug has been confirmed by popular vote. ***
Comment 9 Dan Meltzer 2007-11-14 23:20:10 UTC
Bumping version, updating.. With the general rewrite going on in 2.0 it is a good time to make sure this happens.
Comment 10 Lydia Pintscher 2008-08-19 19:24:35 UTC
Do we want this in Amarok 2?
Comment 11 Simon ESNEAULT 2009-06-19 14:38:58 UTC
There are already plenty of ways to add / queue / append album in amarok 2.1 ...

Close this bug for now. anyone can reopen and argue if necessary .