Bug 96458 - KMail provides link to add vcard even though the vcard is already in the addressbook
Summary: KMail provides link to add vcard even though the vcard is already in the addr...
Status: RESOLVED FIXED
Alias: None
Product: kmail2
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR wishlist
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-01-06 18:56 UTC by Esben Mose Hansen
Modified: 2012-10-05 18:02 UTC (History)
1 user (show)

See Also:
Latest Commit: http://commits.kde.org/kdepim/75a618701aba5cc61f3d75c491c08871885e4b09
Version Fixed In: 4.10

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Esben Mose Hansen 2005-01-06 18:56:19 UTC 
Version:           1.7.1 (using KDE KDE 3.3.1)
Installed from:    Gentoo Packages
Compiler:          gcc 3.4 
OS:                Linux

If an attached vcard is already in the addressbook, the current text:

[Add this contact to the addressbook]

is suboptimal. 
If there is no additional or changed information in the vcard the text should be:

[contact already in addressbook]

If there vcard contains additional or different fields compared to the one in the addressbook, the text should be:
[Update this contact in the addressbook]

This should be an healthy exercise for a Kmail wannabe-developer.
Comment 1 Ferdinand Gassauer 2006-08-01 11:14:59 UTC 
at least it should open the kontact instead of issuing the message "..is already in..."
Comment 2 Laurent Montel 2012-10-05 18:01:26 UTC 
Git commit 75a618701aba5cc61f3d75c491c08871885e4b09 by Montel Laurent.
Committed on 05/10/2012 at 20:00.
Pushed by mlaurent into branch 'master'.

Fix Bug 96458 - KMail provides link to add vcard even though the vcard

is already in the addressbook
FIXED-IN: 4.10

M  +64   -15   plugins/messageviewer/bodypartformatter/text_vcard.cpp
M  +75   -3    plugins/messageviewer/bodypartformatter/vcardmemento.cpp
M  +25   -0    plugins/messageviewer/bodypartformatter/vcardmemento.h

http://commits.kde.org/kdepim/75a618701aba5cc61f3d75c491c08871885e4b09