Bug 95346 - Action merging merges actions into kmail
Summary: Action merging merges actions into kmail
Status: RESOLVED FIXED
Alias: None
Product: akregator
Classification: Applications
Component: kontact plugin (show other bugs)
Version: cvs
Platform: Unlisted Binaries Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-12-17 18:12 UTC by Frank Osterfeld
Modified: 2004-12-21 21:27 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Frank Osterfeld 2004-12-17 18:12:30 UTC
I use KDE 3.3 with KDE-PIM HEAD. 
 
1) Open Kontact, select Akregator plugin 
2) Open a page viewer 
3) Switch to KMail plugin 
 
Akregator actions are merged into KMail (looks funny).
Comment 1 Frank Osterfeld 2004-12-21 21:27:07 UTC
CVS commit by osterfeld: 

Don't break kontact. Remove nested part actions when deselecting akregator plugin.
BUG: 95346


  M +14 -1     akregator_part.cpp   1.122
  M +2 -0      akregator_part.h   1.52


--- kdepim/akregator/src/akregator_part.cpp  #1.121:1.122
@@ -685,4 +685,17 @@ void aKregatorPart::showOptions()
 }
 
+void aKregatorPart::partActivateEvent(KParts::PartActivateEvent* event)
+{
+    if (factory() && m_mergedPart)
+    {
+        if (event->activated())
+            factory()->addClient(m_mergedPart);
+        else
+            factory()->removeClient(m_mergedPart);
+    }
+
+    KPIM::Part::partActivateEvent(event);
+}
+
 KParts::Part *aKregatorPart::hitTest(QWidget *widget, const QPoint &globalPos)
 {

--- kdepim/akregator/src/akregator_part.h  #1.51:1.52
@@ -167,4 +167,6 @@ namespace Akregator
             virtual KParts::Part *hitTest(QWidget *widget, const QPoint &globalPos);
 
+            /** reimplemented to load/unload the merged parts on selection/deselection */ 
+            virtual void partActivateEvent(KParts::PartActivateEvent* event);
         public slots:
             /**