Version: 1.2-CVS (using KDE Devel) Installed from: Compiled sources OS: Linux Dear amaroK developers, there is a problem in submitting to Audioscrobbler if the artist/title name is non latin (namely, it is Unicode). The garbage characters you can see here [1] are gone after applying the attached patch. It seems Audioscrobbler does not like encoded URL. I tested the patch with Cyrillic, Japanese and Chinese artist/title names. The results you can see here [1]. Please consider applying the attached patch. [1] http://www.audioscrobbler.com:80/user/kmashrab/ Thanks.
Created attachment 8670 [details] A patch to fix Audioscrobbler URL encoding problem
I think Daniel Molkentin fixed this last night.
Yes it is fixed. Daniel's fix is much more elegant than mine. There is one more fix to make, I think. Namely, in void Scrobbler::similarArtists( const QString & artist ) line .arg( KURL::encode_string_no_slash( artist.utf8() ) ); should be .arg( KURL::encode_string_no_slash( artist ) ); It is like what Daniel did for Audioscrobbler submit URL encoding fix.
Daniel reverted his URL encoding changes. Thus, the report is valid again. I'm going to reopen it. I reset my Audioscrobbler statistics, I do not feel like playing with it. For testing I created a new accout at Audioscrobbler.com, it is amarok_user. The garbage characters one can see at http://www.audioscrobbler.com:80/user/amarok_user/ is after revert.
Guys, could you every come to a conscensus as to what the right code is? Perhaps you could discuss this with Daniel, over a cup of tea.
Mashrab, please test again with current CVS; I hope I got it correctly this time :)
I tested recent amarok CVS with Audioscrobbler.com and confirm it works properly. Thanks Lukas.