Version: 0.8.1 (using KDE KDE 3.2.1) Installed from: SuSE RPMs From the handbook: 'It is possible to mark a range of expressions. You can then modify one or more properties from the selection or save them as a new file.' Saving a selection as a new file can be done by selecting a number of rows and using the 'Save Selected Area' command from the 'Edit' menu. However the program does not save the selection but the entire file under the new name that you specify. Futhermore I think that this command should be part of the file menu, just after the 'Save As...' command. Marc
There seems to be a bad choice of wording and/or function here. What the code actually does is saving the entries that are marked as being in the query, i.e. have a green check mark in the second column. It does not save entries highlighted by a selection in the table. The question is what is preferable? 1. Saving entries in query as now? Requires change of menu item caption and documentation. 2. Saving entries highlighted by a selection? Requires change in code and clarification in documentation. 3. Neither 1 nor 2? 4. Both 1 and 2? I think 1 was the intended behavior since 2 can be achieved by a combination of Delete and Save As.
CVS commit by hedlund: GUI: Move and rename command for saving vocabulary entries marked as In Query as a new vocabulary. BUG: 94678 M +7 -7 doc/kvoctrain/index.docbook 1.33 M +5 -5 kvoctrain/kvoctrain/kva_init.cpp 1.49 M +1 -1 kvoctrain/kvoctrain/kvoctrainui.rc 1.2 --- kdeedu/doc/kvoctrain/index.docbook #1.32:1.33 @@ -917,4 +917,11 @@ <varlistentry> + <term><menuchoice> + <guimenu>File</guimenu> + <guimenuitem>Save Entries In Query As...</guimenuitem></menuchoice></term> + <listitem><para><action>Saves the entries marked In Query as a new vocabulary.</action></para></listitem> +</varlistentry> + +<varlistentry> <term> <menuchoice><guimenu>File</guimenu> @@ -1026,11 +1033,4 @@ </varlistentry> -<varlistentry> -<term><menuchoice> -<guimenu>Edit</guimenu> -<guimenuitem>Save selected area...</guimenuitem></menuchoice></term> -<listitem><para><action>Saves the selection to a - file.</action></para></listitem> -</varlistentry> </variablelist> --- kdeedu/kvoctrain/kvoctrain/kva_init.cpp #1.48:1.49 @@ -163,6 +163,6 @@ void kvoctrainApp::initActions() editRemoveSelectedArea->setToolTip(editRemoveSelectedArea->whatsThis()); - editSaveSelectedArea = new KAction(i18n("Sa&ve Selected Area"), KGlobal::iconLoader()->loadIcon("filesave", KIcon::Small), 0, this, SLOT(slotSaveSelection()), actionCollection(),"edit_save_selected_area"); - editSaveSelectedArea->setWhatsThis(i18n("Saves the selected rows as a new vocabulary")); + editSaveSelectedArea = new KAction(i18n("Save E&ntries In Query As..."), KGlobal::iconLoader()->loadIcon("filesaveas", KIcon::Small), 0, this, SLOT(slotSaveSelection()), actionCollection(),"edit_save_selected_area"); + editSaveSelectedArea->setWhatsThis(i18n("Saves the entries in the query as a new vocabulary")); editSaveSelectedArea->setToolTip(editSaveSelectedArea->whatsThis()); --- kdeedu/kvoctrain/kvoctrain/kvoctrainui.rc #1.1:1.2 @@ -6,4 +6,5 @@ <Separator append="open_merge" /> <Action append="open_merge" name="file_merge" /> + <Action append="save_merge" name="edit_save_selected_area" /> <Separator/> </Menu> @@ -13,5 +14,4 @@ <Action name="edit_edit_selected_area" /> <Action name="edit_remove_selected_area" /> - <Action name="edit_save_selected_area" /> </Menu> <Menu name="vocabulary" >