Bug 93651 - Label editor: size can't be <0
Summary: Label editor: size can't be <0
Status: RESOLVED FIXED
Alias: None
Product: kst
Classification: Applications
Component: general (show other bugs)
Version: 1.x
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: kst
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-11-21 02:26 UTC by Netterfield
Modified: 2004-11-23 01:29 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
labelsize.patch (657 bytes, text/x-diff)
2004-11-23 00:51 UTC, Netterfield
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Netterfield 2004-11-21 02:26:01 UTC
Version:           1.0.0_pre1 (using KDE 3.3.1, Gentoo)
Compiler:          gcc version 3.3.4 20040623 (Gentoo Linux 3.3.4-r1, ssp-3.3.2-2, pie-8.7.6)
OS:                Linux (i686) release 2.6.8-gentoo-r3

In the label Edit dialog, the text size is forced to be >=0.  Negative values should be allowed, as this size is relative to a default size.
Comment 1 Netterfield 2004-11-23 00:51:44 UTC
OK... so it's a tiny bug, but it is also easy to fix.  Here is a patch



Created an attachment (id=8387)
labelsize.patch
Comment 2 George Staikos 2004-11-23 01:23:20 UTC
On Monday 22 November 2004 18:51, netterfield@astro.utoronto.ca wrote:
> 00:51 ------- OK... so it's a tiny bug, but it is also easy to fix.  Here
> is a patch
>

  The patch is obvious and I don't mind it going in, but did you test the 
various sizes to see if they make sense?  Are they keyed to the Qt default 
font size as well?  I noticed font sizes were sometimes quite strange when I 
was in Paris, but I didn't investigate this fully.

Comment 3 Netterfield 2004-11-23 01:27:03 UTC
If there are other bugs (other than minimum size in the spin box) in the font 
sizes, this fix does not fix them.

However, this does let you make the font small, and the sizes all seem 
sensible.


On Monday 22 November 2004 19:23, George Staikos wrote:
> ------- You are receiving this mail because: -------
> You are the assignee for the bug, or are watching the assignee.
>
> http://bugs.kde.org/show_bug.cgi?id=93651
>
>
>
>
> ------- Additional Comments From staikos kde org  2004-11-23 01:23 -------
>
> On Monday 22 November 2004 18:51, netterfield astro utoronto ca wrote:
> > 00:51 ------- OK... so it's a tiny bug, but it is also easy to fix.  Here
> > is a patch
>
>   The patch is obvious and I don't mind it going in, but did you test the
> various sizes to see if they make sense?  Are they keyed to the Qt default
> font size as well?  I noticed font sizes were sometimes quite strange when
> I was in Paris, but I didn't investigate this fully.
> _______________________________________________
> Kst mailing list
> Kst@kde.org
> https://mail.kde.org/mailman/listinfo/kst

Comment 4 Netterfield 2004-11-23 01:29:13 UTC
CVS commit by netterfield: 

Allow small fonts in floating labels.  

Approval: George
BUG: 93651


  M +3 -0      kstlabeldialog.ui   1.12


--- kdeextragear-2/kst/kst/kstlabeldialog.ui  #1.11:1.12
@@ -34,4 +34,7 @@
                 <cstring>FontSize</cstring>
             </property>
+             <property name="minValue">
+                 <number>-12</number>
+             </property>
         </widget>
         <widget class="QLabel" row="2" column="4">