Bug 93039 - curve appearance for bar graphs is not drawn
Summary: curve appearance for bar graphs is not drawn
Status: RESOLVED FIXED
Alias: None
Product: kst
Classification: Applications
Component: ui (show other bugs)
Version: 1.x
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: kst
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-11-10 18:06 UTC by George Staikos
Modified: 2010-08-14 14:40 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
Fix for 93039 (7.55 KB, patch)
2004-11-11 20:54 UTC, Andrew Walker
Details
bargraph.patch (2.16 KB, text/x-diff)
2004-11-11 23:37 UTC, George Staikos
Details

Note You need to log in before you can comment on or make changes to this bug.
Description George Staikos 2004-11-10 18:06:31 UTC
The curve appearance preview in dialogs is not drawn for bar graphs.
Comment 1 Andrew Walker 2004-11-11 20:54:07 UTC
Created attachment 8255 [details]
Fix for 93039
Comment 2 Andrew Walker 2004-11-11 22:35:27 UTC
The only relevant changes are the ones to curveappearancewidget*
Comment 3 George Staikos 2004-11-11 23:37:02 UTC
On Thursday 11 November 2004 14:54, Andrew Walker wrote:
> ------- Additional Comments From arwalker sumusltd com  2004-11-11 20:54
> ------- Created an attachment (id=8255)
>  --> (http://bugs.kde.org/attachment.cgi?id=8255&action=view)
> Fix for 93039

  Approved for HEAD as this patch.  You can't change the string in HEAD.  
Please apply and close.



Created an attachment (id=8257)
bargraph.patch
Comment 4 Andrew Walker 2004-11-12 03:27:47 UTC
CVS commit by arwalker: 

Draw bars if they are selected.

CCMAIL: 93039-done@bugs.kde.org


  M +14 -0     curveappearancewidget.ui   1.20
  M +16 -2     curveappearancewidget.ui.h   1.17


--- kdeextragear-2/kst/kst/curveappearancewidget.ui  #1.19:1.20
@@ -487,4 +487,16 @@
         <slot>setEnabled(bool)</slot>
     </connection>
+    <connection>
+        <sender>_showBars</sender>
+        <signal>toggled(bool)</signal>
+        <receiver>CurveAppearanceWidget</receiver>
+        <slot>drawLine()</slot>
+    </connection>
+    <connection>
+        <sender>_barStyle</sender>
+        <signal>activated(int)</signal>
+        <receiver>CurveAppearanceWidget</receiver>
+        <slot>drawLine()</slot>
+    </connection>
 </connections>
 <tabstops>
@@ -495,4 +507,6 @@
     <tabstop>_comboLineStyle</tabstop>
     <tabstop>_spinBoxLineWidth</tabstop>
+    <tabstop>_showBars</tabstop>
+    <tabstop>_barStyle</tabstop>
 </tabstops>
 <includes>

--- kdeextragear-2/kst/kst/curveappearancewidget.ui.h  #1.16:1.17
@@ -95,6 +94,21 @@ void CurveAppearanceWidget::drawLine()
 
   p.fillRect(p.window(), QColor("white"));
+
+  if (showBars()) {
+    QRect rectBar((pix.width()-pix.height())/2,
+                  pix.height()/2,
+                  pix.height(),
+                  (pix.height()/2)+1);
+
+    if (barStyle() == 1) {
+      p.fillRect(rectBar,QBrush(QColor(color())));
+      p.setPen(QPen(QColor("black"),lineWidth(),KstLineStyle[lineStyle()]));
+    } else {
   p.setPen(pen);
+    }
+    p.drawRect(rectBar);
+  }
 
+  p.setPen(pen);
   if (_showLines->isChecked()) {
     p.drawLine(1,pix.height()/2,pix.width()-1, pix.height()/2);


Comment 5 Peter Kümmel 2010-08-14 14:40:30 UTC
Change version to 1.x