Bug 92932 - KWallet dialog appears twice in KMail cvs HEAD (when not wanting using KWallet)
Summary: KWallet dialog appears twice in KMail cvs HEAD (when not wanting using KWallet)
Status: RESOLVED FIXED
Alias: None
Product: kmail
Classification: Applications
Component: general (show other bugs)
Version: 1.7.50
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-11-08 21:56 UTC by Anne-Marie Mahfouf
Modified: 2007-12-11 20:18 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Anne-Marie Mahfouf 2004-11-08 21:56:50 UTC
Version:           1.7.50 (using KDE 3.3.89 (CVS >= 20041104), compiled sources)
Compiler:          gcc version 3.4.0
OS:                Linux (i686) release 2.4.22-10mdk

I have 2 receiving accounts and 1 sending account.
New KDEHOME, new KDEDIR cvs HEAD today
When I configure KMail, I for example modify an account, when I click on OK, the KWallet Wizard dialog appears, I click on Cancel,
I then have an Error KMessageBox telling me the KWallet could not be opened (this is wrong as I don't want the KWallet) (also those 2 KWallet dialogs are not on top which is very unfriendly. So I click on OK in this KMessgaeBox, I get a "KWallet is not running message" (which is OK and on top). I click OK on this kmessagebox and hop: another KWallet Wizard dialog (is it because I have 2 Receiving accounts?). I Cancel again, The Error KMessageBox appears again and the "KWallet is not running" then everything stops.

There are 2 bugs here in my opinion: the fact that the KWallet Wizard appears twice and also the fact that the KWallet Wizard appears everytime I go in Configure KMail and click on Apply or OK.
Comment 1 Tom Albers 2004-11-08 22:23:00 UTC
Volker can you look at this?
Comment 2 Volker Krause 2004-11-08 23:06:03 UTC
I think the actual problem is that we handle 'Cancel' more like the wallet 
could not be opened than like 'I don't want to use the wallet at all'.
In the first case it makes sense to try again to open the wallet, thus you get 
a KWallet password prompt for every access to your mail password. And since 
it hasn't been written to the wallet yet, KMail will continue to try to open 
the wallet.
In case you don't want to use the wallet, there are two different ways to 
disable it:
1. Disable it KDE wide: KControl -> Security & Privacy -> KDE Wallet
2. Disable password saving in KMail: "Store password in configuration file" in 
the account settings. (we might want to remove the misleading "in 
configuration file" part here)
Using KWallet everywhere but in KMail and store mail passwords in the (unsafe) 
configuration file is not possible, but I don't think that would make much 
sense.

I agree that this might not be very userfriendly, how is this solved in other 
KDE applications using KWallet? (at least KNode has the same behavior)



Comment 3 Anne-Marie Mahfouf 2004-11-09 01:03:51 UTC
Ok, I installed kdeutils and thus disabled the KWallet system. However the 'KWallet is not running' is also showing twice on Apply and then twice on OK when you are in Configure KMail (provided you don't disable that dialog). This dialog (still if you don't disable it) is also displayed twice when I Quit KMail.


Comment 4 George Staikos 2004-11-09 12:02:45 UTC
Cancelling the wizard will just reopen it on next attempt until you answer yes or no to the question of if you want to use kwallet or not.
Comment 5 Volker Krause 2005-01-07 17:03:06 UTC
CVS commit by vkrause: 

Fix password storage in configuration file.
The user will now be asked once per account if [s]he would like to store the password in the (unsafe) configuration file instead of KWallet (no more message box spam) and - most important - the password is now really stored.

Reviewed by Ingo Kloecker.

BUG: 92932, 93789
CCBUG: 93183, 95615


  M +22 -2     accountdialog.cpp   1.159
  M +52 -22    kmtransport.cpp   1.47
  M +1 -1      kmtransport.h   1.13
  M +41 -12    networkaccount.cpp   1.15
  M +1 -1      networkaccount.h   1.9