The Opening Document and Reading Document strings are very confusing. Most people see those as synonyms, and they are completely indescriptive. We should be a bit more fine-grained, and more descriptive.
My suspiscion is that if we try be more fine-grained we would, in many circumstances, simply end up with messages displaying so quickly in successions that none of them would be readable. My preference would be to leave this as is.
On Sunday 07 November 2004 19:04, Andrew Walker wrote: > ------- My suspiscion is that if we try be more fine-grained we would, in > many circumstances, simply end up with messages displaying so quickly in > successions that none of them would be readable. > > My preference would be to leave this as is. These documents we're working with take 10 minutes or more to load on a very fast machine. We need more feedback.
CVS commit by staikos: more feedback on loading and a delayed instantiation BUG: 92870 M +1 -1 kst.cpp 1.263 M +6 -6 kstdoc.cpp 1.139 --- kdeextragear-2/kst/kst/kst.cpp #1.262:1.263 @@ -804,5 +804,4 @@ bool KstApp::openDocumentFile(const QStr opening = true; KURL url; - QFileInfo finfo(in_filename); bool rc = false; @@ -813,4 +812,5 @@ bool KstApp::openDocumentFile(const QStr setCaption(doc->title()); if (url.isLocalFile()) { + QFileInfo finfo(in_filename); addRecentFile(finfo.absFilePath()); } else { --- kdeextragear-2/kst/kst/kstdoc.cpp #1.138:1.139 @@ -199,7 +199,5 @@ bool KstDoc::openDocument(const KURL& ur KstRVectorPtr vector; KstApp *app = KstApp::inst(); - QString readingDocument = i18n("Reading document"); - QString openingDocument = i18n("Opening document"); - + QString readingDocument = i18n("Reading Kst file"); QDomNode n = docElem.firstChild(); @@ -352,5 +350,4 @@ bool KstDoc::openDocument(const KURL& ur kapp->eventLoop()->processEvents(QEventLoop::ExcludeSocketNotifiers, 10); } - app->slotUpdateProgress(0, 0, openingDocument); if (warnOldKstFile) { @@ -358,4 +355,5 @@ bool KstDoc::openDocument(const KURL& ur } + app->slotUpdateProgress(0, 0, i18n("Creating plots")); // // if we have anything left in plotHolderWhileOpeningDocument then @@ -396,4 +394,5 @@ bool KstDoc::openDocument(const KURL& ur KstApp::inst()->plotHolderWhileOpeningDocument().clear(); + app->slotUpdateProgress(0, 0, i18n("Loading data")); // // lazy load data @@ -432,4 +431,5 @@ bool KstDoc::openDocument(const KURL& ur createScalars(); + app->slotUpdateProgress(0, 0, i18n("Synchronizing data")); // // update plots now that lazy loading is done
Change version to 1.x