Version: 0.7 beta 1 (using KDE KDE 3.3.0) Compiler: gcc 3.3.4 OS: Linux When I open the 'Find duplicate images' dialog (from an album's context menu), go to the 'Method and Cache' section and click on 'Purge Cahce (albums selected)', I get an error message saying "You must select at least one Album for the purge cache process.". The funny thing is that this happens always, no matter how many albums I select in 'Selection' section of this dialog box.
CVS commit by jahrens: fixed in cvs CCMAIL: 91548-done@bugs.kde.org, digikam-devel@lists.sourceforge.net M +2 -1 finddupplicatedialog.cpp 1.26 --- kdeextragear-libs-1/kipi-plugins/findimages/finddupplicatedialog.cpp #1.25:1.26 @@ -257,5 +257,6 @@ void FindDuplicateDialog::slotUpdateCach void FindDuplicateDialog::slotPurgeCache(void) { - QValueList<KIPI::ImageCollection> albumsList = getSelectedAlbums(); + QValueList<KIPI::ImageCollection> albumsList = + m_imageCollectionSelector->selectedImageCollections(); QStringList albumsListPath;
CVS commit by jahrens: Addition to #91548 CCMAIL: 91548@bugs.kde.org, digikam-devel@lists.sourceforge.net M +10 -4 finddupplicatedialog.cpp 1.27 M +1 -2 finddupplicatedialog.h 1.11 --- kdeextragear-libs-1/kipi-plugins/findimages/finddupplicatedialog.cpp #1.26:1.27 @@ -257,6 +257,6 @@ void FindDuplicateDialog::slotUpdateCach void FindDuplicateDialog::slotPurgeCache(void) { - QValueList<KIPI::ImageCollection> albumsList = - m_imageCollectionSelector->selectedImageCollections(); + QValueList<KIPI::ImageCollection> albumsList = getSelectedAlbums(); + QStringList albumsListPath; @@ -287,6 +287,4 @@ void FindDuplicateDialog::slotPurgeAllCa void FindDuplicateDialog::slotOk() { - m_selectedAlbums = m_imageCollectionSelector->selectedImageCollections(); - if (getSelectedAlbums().isEmpty() == true) { @@ -301,4 +299,12 @@ void FindDuplicateDialog::slotOk() ///////////////////////////////////////////////////////////////////////////////////////////// +QValueList<KIPI::ImageCollection> FindDuplicateDialog::getSelectedAlbums() const +{ + return m_imageCollectionSelector->selectedImageCollections(); +} + + +///////////////////////////////////////////////////////////////////////////////////////////// + const QString FindDuplicateDialog::getFindMethod() const { --- kdeextragear-libs-1/kipi-plugins/findimages/finddupplicatedialog.h #1.10:1.11 @@ -69,5 +69,5 @@ class FindDuplicateDialog : public KDial void setApproximateThreeshold(int Value); - QValueList<KIPI::ImageCollection> getSelectedAlbums() const { return m_selectedAlbums; } + QValueList<KIPI::ImageCollection> getSelectedAlbums() const; signals: @@ -99,5 +99,4 @@ class FindDuplicateDialog : public KDial KIPI::Interface *m_interface; - QValueList<KIPI::ImageCollection> m_selectedAlbums; KIPI::ImageCollectionSelector *m_imageCollectionSelector;
Le mardi 19 Octobre 2004 21:31, Joern Ahrens a écrit : > ------- You are receiving this mail because: ------- > You are the assignee for the bug, or are watching the assignee. > > http://bugs.kde.org/show_bug.cgi?id=91548 > > > > > ------- Additional Comments From kde jokele de 2004-10-19 21:31 ------- > CVS commit by jahrens: > > > Addition to #91548 > > CCMAIL: 91548 bugs kde org, digikam-devel lists sourceforge net > > > M +10 -4 finddupplicatedialog.cpp 1.27 > M +1 -2 finddupplicatedialog.h 1.11 > > > --- kdeextragear-libs-1/kipi-plugins/findimages/finddupplicatedialog.cpp > #1.26:1.27 @ -257,6 +257,6 @ void FindDuplicateDialog::slotUpdateCach > void FindDuplicateDialog::slotPurgeCache(void) > { > - QValueList<KIPI::ImageCollection> albumsList = > - m_imageCollectionSelector->selectedImageCollections(); > + QValueList<KIPI::ImageCollection> albumsList = getSelectedAlbums(); > + > QStringList albumsListPath; > > @ -287,6 +287,4 @ void FindDuplicateDialog::slotPurgeAllCa > void FindDuplicateDialog::slotOk() > { > - m_selectedAlbums = > m_imageCollectionSelector->selectedImageCollections(); - > if (getSelectedAlbums().isEmpty() == true) > { > @ -301,4 +299,12 @ void FindDuplicateDialog::slotOk() > > /////////////////////////////////////////////////////////////////////////// >////////////////// > > +QValueList<KIPI::ImageCollection> FindDuplicateDialog::getSelectedAlbums() > const +{ > + return m_imageCollectionSelector->selectedImageCollections(); > +} > + > + > +////////////////////////////////////////////////////////////////////////// >/////////////////// + > const QString FindDuplicateDialog::getFindMethod() const > { > > --- kdeextragear-libs-1/kipi-plugins/findimages/finddupplicatedialog.h > #1.10:1.11 @ -69,5 +69,5 @ class FindDuplicateDialog : public KDial > void setApproximateThreeshold(int Value); > > - QValueList<KIPI::ImageCollection> getSelectedAlbums() const { return > m_selectedAlbums; } + QValueList<KIPI::ImageCollection> > getSelectedAlbums() const; > > signals: > @ -99,5 +99,4 @ class FindDuplicateDialog : public KDial > KIPI::Interface *m_interface; > > - QValueList<KIPI::ImageCollection> m_selectedAlbums; > KIPI::ImageCollectionSelector *m_imageCollectionSelector; > _______________________________________________ > Kde-imaging mailing list > Kde-imaging@kde.org > https://mail.kde.org/mailman/listinfo/kde-imaging Thanks for this patch Joern ! Gilles
Not reproducible with 7.0.0-beta1