Version: 1.7.50 (using KDE 3.3.89 (CVS >= 20040820), compiled sources) Compiler: gcc version 3.3.3 (SuSE Linux) OS: Linux (i686) release 2.6.5-7.108-smp Hi! IMHO it would be useful to have a search/find available to search in the mail body (long texts) like in any other html page cu ferdinand
Edit -> Find in Message (ctrl-f) ? What's missing there for you?
well I ment after opening the message in a seperate window there is a minimal navigation toolbar, which is not configurable and CTRL-f is not implemented there
I agree. I needed that feature today and was surprised that it didn't exist. Please, roadmap this feature and add a button for it into toolbar. I'll vote for this bug. I think there should be an option to disable the preview part from main window anyway, it's generating unnecsessary traffic when you move around in the message list. But that's worth of its own wish bug.
*** Bug 113131 has been marked as a duplicate of this bug. ***
SVN commit 590039 by zangl: Adds an "Edit" menu to the reader window: - Copy - Select All - Find - Find Next - Move to Trash (moved here from the File menu) BUGS: 90584 M +33 -5 kmreadermainwin.cpp M +4 -0 kmreadermainwin.h M +6 -3 kmreadermainwin.rc M +6 -0 kmreaderwin.cpp M +2 -0 kmreaderwin.h --- branches/KDE/3.5/kdepim/kmail/kmreadermainwin.cpp #590038:590039 @@ -144,6 +144,29 @@ } //----------------------------------------------------------------------------- +void KMReaderMainWin::slotFind() +{ + mReaderWin->slotFind(); +} + +void KMReaderMainWin::slotFindNext() +{ + mReaderWin->slotFindNext(); +} + +//----------------------------------------------------------------------------- +void KMReaderMainWin::slotCopy() +{ + mReaderWin->slotCopySelectedText(); +} + +//----------------------------------------------------------------------------- +void KMReaderMainWin::slotMarkAll() +{ + mReaderWin->selectAll(); +} + +//----------------------------------------------------------------------------- void KMReaderMainWin::slotPrintMsg() { KMCommand *command = new KMPrintCommand( this, mReaderWin->message(), @@ -262,11 +285,6 @@ // this, SLOT( slotSaveMsg() ), // actionCollection(), "file_save_as" ); - mTrashAction = new KAction( KGuiItem( i18n("&Move to Trash"), "edittrash", - i18n("Move message to trashcan") ), - Key_Delete, this, SLOT(slotTrashMsg()), - actionCollection(), "move_to_trash" ); - mPrintAction = KStdAction::print( this, SLOT( slotPrintMsg() ), actionCollection() ); @@ -275,6 +293,16 @@ closeShortcut.append( KKey(Key_Escape)); closeAction->setShortcut(closeShortcut); + //----- Edit Menu + KStdAction::copy( this, SLOT( slotCopy() ), actionCollection() ); + KStdAction::selectAll( this, SLOT( slotMarkAll() ), actionCollection() ); + KStdAction::find( this, SLOT(slotFind()), actionCollection() ); + KStdAction::findNext( this, SLOT( slotFindNext() ), actionCollection() ); + mTrashAction = new KAction( KGuiItem( i18n( "&Move to Trash" ), "edittrash", + i18n( "Move message to trashcan" ) ), + Key_Delete, this, SLOT( slotTrashMsg() ), + actionCollection(), "move_to_trash" ); + //----- View Menu mViewSourceAction = new KAction( i18n("&View Source"), Key_V, this, SLOT(slotShowMsgSrc()), actionCollection(), --- branches/KDE/3.5/kdepim/kmail/kmreadermainwin.h #590038:590039 @@ -49,6 +49,10 @@ void slotForwardDigestMsg(); void slotRedirectMsg(); void slotShowMsgSrc(); + void slotMarkAll(); + void slotCopy(); + void slotFind(); + void slotFindNext(); void slotConfigChanged(); --- branches/KDE/3.5/kdepim/kmail/kmreadermainwin.rc #590038:590039 @@ -1,5 +1,5 @@ <!DOCTYPE kpartgui> -<kpartgui version="6" name="kmreadermainwin" > +<kpartgui version="7" name="kmreadermainwin" > <MenuBar> <Menu noMerge="1" name="file" > <text>&File</text> @@ -7,10 +7,13 @@ <Action name="file_save_as" /> <Action name="file_print" /> <Separator/> - <Action name="move_to_trash" /> - <Separator/> <Action name="file_close" /> </Menu> + <Menu name="edit" > + <text>&Edit</text> + <Action name="move_to_trash" /> + </Menu> + <Menu noMerge="1" name="view"> <text>&View</text> <Action name="view_headers"/> --- branches/KDE/3.5/kdepim/kmail/kmreaderwin.cpp #590038:590039 @@ -1949,6 +1949,12 @@ } //----------------------------------------------------------------------------- +void KMReaderWin::slotFindNext() +{ + mViewer->findTextNext(); +} + +//----------------------------------------------------------------------------- void KMReaderWin::slotToggleFixedFont() { QScrollView * scrollview = static_cast<QScrollView *>(mViewer->widget()); --- branches/KDE/3.5/kdepim/kmail/kmreaderwin.h #590038:590039 @@ -321,6 +321,8 @@ /** The user selected "Find" from the menu. */ void slotFind(); + /** The user selected "Find Next" from the menu. */ + void slotFindNext(); /** The user toggled the "Fixed Font" flag from the view menu. */ void slotToggleFixedFont();