Bug 90503 - Support for "Part of a set" (TPOS) ID3v2 frame
Summary: Support for "Part of a set" (TPOS) ID3v2 frame
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: general (show other bugs)
Version: 1.1
Platform: Debian testing Linux
: NOR wishlist
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
: 108235 109903 111354 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-09-29 21:44 UTC by Ilya Konstantinov
Modified: 2006-06-11 12:32 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
support for composer/dicsnumber tags in flac files (2.88 KB, patch)
2006-01-07 00:20 UTC, Piotr Czerwinski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Konstantinov 2004-09-29 21:44:29 UTC
Version:           1.1 (using KDE KDE 3.3.0)
Installed from:    Debian testing/unstable Packages

Often users append text such as "CD #2" to the album name (TALB frame), to describe which part of the album a song belongs to.
ID3v2 has a designated frame type for this information: the TPOS frame.
If users would set this frame instead of appending this information in TALB, we could more easily look-up the album names in Amazon etc.
Therefore, it would be good to add support for this frame.

BTW, TagLib supports this frame, though not through the naive API. Bug 77926 provides a code sample for this.
Comment 1 Stéphane Pontier 2005-02-19 23:56:18 UTC
*** This bug has been confirmed by popular vote. ***
Comment 2 Alexandre Oliveira 2005-06-27 23:09:19 UTC
*** Bug 108235 has been marked as a duplicate of this bug. ***
Comment 3 Seb Ruiz 2005-08-23 15:45:21 UTC
*** Bug 111354 has been marked as a duplicate of this bug. ***
Comment 4 LD Steiner 2005-09-08 01:54:43 UTC
FLAC and Vorbis files commonly have "DISC" and "DISCNUMBER" tags for the same purpose. There's good discussion of how they can be useful at http://www.hydrogenaudio.org/forums/lofiversion/index.php/t31872.html and I'd like to request grouping discs together, preferably by "DISCNUMBER" first and "DISC" after, for maximum flexibility per that discussion. (See the example about Enya's "A Box Of Dreams" set.)
Comment 5 Seb Ruiz 2005-11-12 13:19:51 UTC
*** Bug 109903 has been marked as a duplicate of this bug. ***
Comment 6 Alexandre Oliveira 2005-12-24 02:35:09 UTC
SVN commit 490984 by aoliveira:

Support for Composer and Disc Number tags, for mp3 (id3v2) and ogg vorbis. They show up on tagdialog, and can be use as playlist columns.
MetaBundle is now also used to save tag changes, to avoid code duplication (as there's code to handle these extra tags).
Collection Scanner also uses tag dialog, to be able to use these tags as well.
Collection version bumped, rescan required.
BUG: 110675
BUG: 90503


 M  +2 -0      ChangeLog  
 M  +21 -8     src/collectiondb.cpp  
 M  +4 -2      src/collectiondb.h  
 M  +1 -0      src/collectionscanner/Makefile.am  
 M  +18 -25    src/collectionscanner/collectionscanner.cpp  
 M  +138 -5    src/metabundle.cpp  
 M  +35 -5     src/metabundle.h  
 M  +48 -41    src/playlist.cpp  
 M  +27 -1     src/playlistitem.cpp  
 M  +16 -0     src/playlistitem.h  
 M  +3 -1      src/scancontroller.cpp  
 M  +34 -44    src/tagdialog.cpp  
 M  +6 -0      src/tagdialog.h  
 M  +138 -76   src/tagdialogbase.ui  
 M  +1 -1      src/tagguesser.cpp  
Comment 7 Piotr Czerwinski 2006-01-07 00:20:54 UTC
Created attachment 14161 [details]
support for composer/dicsnumber tags in flac files

I know it has been marked as resolved but I believe that flac files should be
also supported here. At least I missed it much.
The patch is attached. I don't claim its perfect and maybe I missed something
(I don't know amarok project at all). But it works for me so maybe you'll find
it usefull too.